From nobody Thu May 23 12:10:39 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VlRpH3SGHz5Lb68; Thu, 23 May 2024 12:10:47 +0000 (UTC) (envelope-from mike@karels.net) Received: from mail2.karels.net (mail2.karels.net [3.19.118.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "freebsd", Issuer "freebsd" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VlRpG73Jwz44Qj; Thu, 23 May 2024 12:10:46 +0000 (UTC) (envelope-from mike@karels.net) Authentication-Results: mx1.freebsd.org; none Received: from mail2.karels.net (localhost [IPv6:0:0:0:0:0:0:0:1]) by mail2.karels.net (8.18.1/8.18.1) with ESMTP id 44NCAetO057666; Thu, 23 May 2024 07:10:40 -0500 (CDT) (envelope-from mike@karels.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=karels.net; s=mail2; t=1716466240; bh=3QNc7kbajhGmI2iL6yiiMcI8k6pHYBOx02IZbVtgsU8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=bDZsDmQBeDkC7S4ArjiF65AS5aVR4QXiu/q5r8ytVhoH2ChTA7jyG8kW8MZiPo11v yo9zSpdguhvCp3v21qN3yjRvtQpzVtdvS4XfG3B63h6c+u0FUbez8hJSrHrZNt0i+8 DVFkSK4mZ89ArrR1dpWjFzbiS1k4oLrmNXpQgtyiasxxpephADihIw9qC2rkZiHCJ2 s7+Ixi/MCjtpboDXti3D24eaYz3ZVmqdk3JWt2WHM99Iw3bllXIavppalqYhg2dTBT iJ7bAqfkoyt694D9eZjms2rZPIIHtZ/OxbnrU2HQd0JBZ3oO5I5ewS0zUSrmMo9lmN dOxxSjIK/WfJQ== Received: from [10.0.2.130] ([73.62.165.147]) by mail2.karels.net with ESMTPSA id 344sG0AyT2ZA4QAAs/W3XQ (envelope-from ); Thu, 23 May 2024 07:10:40 -0500 From: Mike Karels To: Baptiste Daroussin , Michael Osipov Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: aa48259f3371 - main - periodic.conf: remove long deprecated security_daily_compat_var() Date: Thu, 23 May 2024 07:10:39 -0500 X-Mailer: MailMate (1.14r6030) Message-ID: <648BD801-F3C0-40DD-B500-CB71177A6748@karels.net> In-Reply-To: References: <202405030740.4437eWUC034126@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.16.0.0/14, country:US] X-Rspamd-Queue-Id: 4VlRpG73Jwz44Qj On 22 May 2024, at 10:07, Baptiste Daroussin wrote: > On Fri 03 May 07:40, Michael Osipov wrote: >> The branch main has been updated by michaelo: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=3Daa48259f337100e79933d66= 0fec8856371f761ed >> >> commit aa48259f337100e79933d660fec8856371f761ed >> Author: Michael Osipov >> AuthorDate: 2024-04-15 11:05:17 +0000 >> Commit: Michael Osipov >> CommitDate: 2024-05-03 07:38:55 +0000 >> >> periodic.conf: remove long deprecated security_daily_compat_var() >> >> This function is documented to be gone in after 11. Time to remove= this >> compat shim. >> >> PR: 275296 >> Reviewed by: jrm (mentor) >> MFC after: 1 month >> Differential Revision: https://reviews.freebsd.org/D44796 > > this broke pkg's periodic script, I would have appreciated a heads up t= o give me > time to prepare a release compatible prior this commit. > > This also breaks some ports. > > Bapt This produces almost a dozen failure messages in the daily security email= =2E Given that the deprecated function was still in use, it should not be rem= oved. Michael, please revert this. Mike