Date: Mon, 22 Apr 2019 21:26:31 +0000 (UTC) From: Enji Cooper <ngie@FreeBSD.org> To: src-committers@freebsd.org, svn-src-projects@freebsd.org Subject: svn commit: r346584 - projects/runtime-coverage-v2/share/mk Message-ID: <201904222126.x3MLQVb1066287@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: ngie Date: Mon Apr 22 21:26:30 2019 New Revision: 346584 URL: https://svnweb.freebsd.org/changeset/base/346584 Log: Update the comment above the coverage COMPILER_FEATURES test Modified: projects/runtime-coverage-v2/share/mk/bsd.lib.mk projects/runtime-coverage-v2/share/mk/bsd.prog.mk Modified: projects/runtime-coverage-v2/share/mk/bsd.lib.mk ============================================================================== --- projects/runtime-coverage-v2/share/mk/bsd.lib.mk Mon Apr 22 21:24:08 2019 (r346583) +++ projects/runtime-coverage-v2/share/mk/bsd.lib.mk Mon Apr 22 21:26:30 2019 (r346584) @@ -5,7 +5,8 @@ .include <bsd.init.mk> .include <bsd.compiler.mk> -# TODO: this shouldn't be here. +# This forces coverage off if the compiler isn't capable, as src.opts.mk is too +# late sometimes. .if !${COMPILER_FEATURES:Mcoverage} MK_COVERAGE:= no .endif Modified: projects/runtime-coverage-v2/share/mk/bsd.prog.mk ============================================================================== --- projects/runtime-coverage-v2/share/mk/bsd.prog.mk Mon Apr 22 21:24:08 2019 (r346583) +++ projects/runtime-coverage-v2/share/mk/bsd.prog.mk Mon Apr 22 21:26:30 2019 (r346584) @@ -4,7 +4,8 @@ .include <bsd.init.mk> .include <bsd.compiler.mk> -# TODO: this shouldn't be here. +# This forces coverage off if the compiler isn't capable, as src.opts.mk is too +# late sometimes. .if !${COMPILER_FEATURES:Mcoverage} MK_COVERAGE:= no .endif
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201904222126.x3MLQVb1066287>