From owner-freebsd-current@freebsd.org Thu Aug 1 19:42:21 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 783B2C77D3; Thu, 1 Aug 2019 19:42:21 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "troutmask", Issuer "troutmask" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 46010F2GwSz4ByF; Thu, 1 Aug 2019 19:42:20 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id x71JgIVl032469 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Thu, 1 Aug 2019 12:42:18 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id x71JgIM4032468; Thu, 1 Aug 2019 12:42:18 -0700 (PDT) (envelope-from sgk) Date: Thu, 1 Aug 2019 12:42:18 -0700 From: Steve Kargl To: Mark Johnston Cc: freebsd-x11@freebsd.org, freebsd-current@freebsd.org Subject: Re: drm-legacy is broken, again Message-ID: <20190801194218.GA32463@troutmask.apl.washington.edu> Reply-To: sgk@troutmask.apl.washington.edu References: <20190801191009.GA8229@troutmask.apl.washington.edu> <20190801192227.GB19051@raichu> <20190801193024.GA29819@troutmask.apl.washington.edu> <20190801193115.GC19051@raichu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190801193115.GC19051@raichu> User-Agent: Mutt/1.12.1 (2019-06-15) X-Rspamd-Queue-Id: 46010F2GwSz4ByF X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.89 / 15.00]; NEURAL_HAM_SHORT(-0.89)[-0.892,0]; REPLY(-4.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Aug 2019 19:42:21 -0000 On Thu, Aug 01, 2019 at 03:31:15PM -0400, Mark Johnston wrote: > On Thu, Aug 01, 2019 at 12:30:24PM -0700, Steve Kargl wrote: > > On Thu, Aug 01, 2019 at 03:22:27PM -0400, Mark Johnston wrote: > > > On Thu, Aug 01, 2019 at 12:10:09PM -0700, Steve Kargl wrote: > > > > Just updated /usr/src to top of tree. > > > > > > > > Trying to update drm-legacy port. After > > > > a failed 'make' in /usr/ports/drm-legacy > > > > > > The patch below should fix it. drm was relying on refcount.h including > > > limits.h. > > > > > > diff --git a/src/dev/drm2/drmP.h b/src/dev/drm2/drmP.h > > > index 3af7ad1..7cbd8db 100644 > > > --- a/src/dev/drm2/drmP.h > > > +++ b/src/dev/drm2/drmP.h > > > @@ -42,6 +42,7 @@ __FBSDID("$FreeBSD$"); > > > > > > #include > > > #include > > > +#include > > > #include > > > #include > > > #include > > > > Thanks for the quick response. I had recalled someone > > has/had been undoing some header pollution changes, > > but the individual names escaped me. > > I reproduced the issue and submitted a PR: > https://github.com/FreeBSDDesktop/drm-legacy/pull/13 Thanks for that, too. I'm not in a position to submit a PR as my mouse has gone missing under Xorg. -- Steve