From owner-svn-src-all@freebsd.org Thu Jun 6 17:48:01 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 75B1115BA9E7; Thu, 6 Jun 2019 17:48:01 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 07735774BE; Thu, 6 Jun 2019 17:48:00 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lf1-f45.google.com with SMTP id a25so810546lfg.2; Thu, 06 Jun 2019 10:48:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=E8bHlqHrw3mz7p0hHVU3cGkeyp6WfViZT3c199TJWmA=; b=GLSez7KT9Vf+POPtBrjN8JoNsNlkSEPy1bn/025qndPAwiAhks3f+JGjTduQIiL0qt +sYaSPtxdFNZQYY4+CHTUrY3uc7FxvcAnY9x2uJp4UAu/Mvjn6OZpixCnAi9IlH9+CFX Wll/vgPsa9ProIlo5htWCYxkEVLapwXFdmbqWI1Wb1rsFw8D7Zl6JMyiMadIrhqDRUWk oj4W2evCGxkILMdsJUEeVbgCTPwLWmXsEXcVFNDrbnvRDMiNWvBXJozemtAxnuvPw5fK hxF/peDXGws0GnL6so+9XWmV1sY+pMiIDmWhQ86wxF9/tLNdm1pjfM5wwJzqtanSQN04 tAHQ== X-Gm-Message-State: APjAAAVXI/YQH6oKqN76BMHgCwx8y94n5+KMpoFkJpVtwbWOP88vU3y3 j6HUtYZ6d2D6/+YGroxwLnaiS+zjvZcdelTbvTm5Jg== X-Google-Smtp-Source: APXvYqw+rRLhZZpxo4CSz2vlbyVRz3HiZTM8NgQe9s7emI2kz11j+vhM20G8uoYo6Rerr0cE0v/DjkokRuTqvJ098x8= X-Received: by 2002:ac2:4202:: with SMTP id y2mr6866589lfh.178.1559842775229; Thu, 06 Jun 2019 10:39:35 -0700 (PDT) MIME-Version: 1.0 References: <201906061504.x56F4odw034764@repo.freebsd.org> <201906061735.x56HZGIJ058845@gndrsh.dnsmgr.net> In-Reply-To: <201906061735.x56HZGIJ058845@gndrsh.dnsmgr.net> From: Alan Somers Date: Thu, 6 Jun 2019 11:39:23 -0600 Message-ID: Subject: Re: svn commit: r348737 - head/sys/kern To: "Rodney W. Grimes" Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 07735774BE X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-0.99)[-0.994,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.99)[-0.989,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Jun 2019 17:48:01 -0000 On Thu, Jun 6, 2019 at 11:35 AM Rodney W. Grimes wrote: > > > Author: asomers > > Date: Thu Jun 6 15:04:50 2019 > > New Revision: 348737 > > URL: https://svnweb.freebsd.org/changeset/base/348737 > > > > Log: > > Add a testing facility to manually reclaim a vnode > > > > Add the debug.try_reclaim_vnode sysctl. When a pathname is written to it, it > > will be reclaimed, as long as it isn't already or doomed. The purpose is to > > gain test coverage for vnode reclamation, which is otherwise hard to > > achieve. > > > > Add the debug.ftry_reclaim_vnode sysctl. It does the same thing, except > > that its argument is a file descriptor instead of a pathname. > > Should not this all be wrapped in some #ifdef or other protection, > is it really a good idea to have this on every single box running > FreeBSD? I initially thought so too, but kib thought that it could be useful for debugging problems in the field. The potential downside is limited, because only root can write to the sysctls, and the worse-case damage is similar to a "umount -f". -Alan