From owner-freebsd-x11@freebsd.org Sat Jul 8 15:16:10 2017 Return-Path: Delivered-To: freebsd-x11@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9B9E7D9C10F for ; Sat, 8 Jul 2017 15:16:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 84233837EA for ; Sat, 8 Jul 2017 15:16:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 8030FD9C10D; Sat, 8 Jul 2017 15:16:10 +0000 (UTC) Delivered-To: x11@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7FCD5D9C10C for ; Sat, 8 Jul 2017 15:16:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6D849837E9 for ; Sat, 8 Jul 2017 15:16:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v68FGA58034261 for ; Sat, 8 Jul 2017 15:16:10 GMT (envelope-from bugzilla-noreply@freebsd.org) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: x11@FreeBSD.org Subject: maintainer-feedback requested: [Bug 220562] [patch] x11-servers/xorg-server: fix terminal initialization in absence of xf86-input-keyboard driver Date: Sat, 08 Jul 2017 15:16:10 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: x11@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-x11@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: X11 on FreeBSD -- maintaining and support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Jul 2017 15:16:10 -0000 Vladimir Kondratyev has reassigned Bugzilla Automation 's request for maintainer-feedback to x11@FreeBSD.org: Bug 220562: [patch] x11-servers/xorg-server: fix terminal initialization in absence of xf86-input-keyboard driver https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220562 --- Description --- Created attachment 184182 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D184182&action= =3Dedit x11-servers.xorg-server.patch Xorg-server is the program that shares framebuffer with the kernel terminal emulator. To avoid interference it must disable terminal output on start and restore on finish. Currently it is done partially by xorg-server itself, partially by and xf86-input-keyboard driver. Switching to xf86-input-evdev or xf86-input-libinput as keyboard events source disables xf86-input-keyboard = and broke terminal handling. Attached patch fixes terminal initialization with copy-pasting missing chun= ks of code from xf86-input-keyboard to xorg-server. Similar changes are already done in Linux-specific parts of xorg-server (See hw/xfree86/os-support/linux/lnx_init.c). Attached patch: 1. Disables processing of special keys (CTRL-C, ALT-Fn) by switching termin= al keyboard to K_RAW mode. 2. Turns off annoying bell on input queue overflow. 3. Disables terminal echoing. It is believed that switching terminal to KD_GRAPHICS mode should do #3, but that is wrong at least on VT consoles.