Date: Sat, 27 Oct 2012 01:31:56 -0700 From: Brian Somers <brian@FreeBSD.org> To: Hiroki Sato <hrs@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, dim@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, brian@FreeBSD.org Subject: Re: svn commit: r242074 - head/etc/rc.d Message-ID: <20121027083156.GA81040@thong.lan.Awfulhak.org> In-Reply-To: <20121027.170139.1459930438153883844.hrs@allbsd.org> References: <20121027.155707.2226765252880570777.hrs@allbsd.org> <20121027072048.GB77528@thong.lan.Awfulhak.org> <20121027.165129.351491404794553651.hrs@allbsd.org> <20121027.170139.1459930438153883844.hrs@allbsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--nFreZHaLTZJo0R7j Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Oct 27, 2012 at 05:01:39PM +0900, Hiroki Sato wrote: > Hiroki Sato <hrs@FreeBSD.org> wrote > in <20121027.165129.351491404794553651.hrs@allbsd.org>: > hr> Thank you. It is explained in section 3.2.4 in > hr> > hr> http://www.freebsd.org/releases/9.0R/relnotes-detailed.html#UPGRADE > hr> > hr> I think it will work as 8.X just after removing the ipv6_enable=3DYES > hr> line in your rc.conf, but after investigating the network.subr > hr> closely I found a bug in backward compatibility of ipv6_enable=3DYES= on > hr> 9.X... Can you try the attached patch? This should fix the issue > hr> even if ipv6_enable=3DYES exists on a 9.X's rc.conf without a patch = to > hr> rc.d/rtadvd. >=20 > Gr, sorry. The previous patch was wrong. The correct one is > attached to this mail. >=20 > -- Hiroki > Index: etc/network.subr > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- etc/network.subr (revision 242114) > +++ etc/network.subr (working copy) > @@ -109,7 +109,9 @@ > # backward compatibility: $ipv6_enable > case $ipv6_enable in > [Yy][Ee][Ss]|[Tt][Rr][Uu][Ee]|[Oo][Nn]|1) > - _ipv6_opts=3D"${_ipv6_opts} accept_rtadv" > + if ! checkyesno ipv6_gateway_enable; then > + _ipv6_opts=3D"${_ipv6_opts} accept_rtadv" > + fi > ;; > esac >=20 > @@ -488,7 +490,11 @@ > # backward compatibility: $ipv6_enable > case $ipv6_enable in > [Yy][Ee][Ss]|[Tt][Rr][Uu][Ee]|[Oo][Nn]|1) > - return 0 > + if checkyesno ipv6_gateway_enable; then > + return 1 > + else > + return 0 > + fi > ;; > esac >=20 Yep, that fixes the issue. Everything works now both with and without ipv6_enable in rc.conf. Thanks for your help. It might be worth asking re@ if the above patch can be squeezed into 9.1 before the release? I'm also ok with backing the original /etc/rc.d/rtadvd change out if you prefer? Thanks again. --=20 Brian Somers <brian@Awfulhak.org> Don't _EVER_ lose your sense of humour ! <brian@FreeBSD.org> --nFreZHaLTZJo0R7j Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iQCVAwUBUIub/A7tvOdmanQhAQK19gQAlK4L2yyMJ4rwSoZgYABKmV7MaNsncPF0 +5TjCnLhO89m57Skq92nnIR5VBVEFaPGnAcbwcFOclu7rq/LNwi8rEtvuey4g9Zv uSf9e6nvvH8FoA+kFBZzokfet/M9GGD7fSJGZqpuzm5+wmYDVV5I+Ulr+QqO0e8r cBIIycuQ4QA= =tdj8 -----END PGP SIGNATURE----- --nFreZHaLTZJo0R7j--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121027083156.GA81040>