From owner-cvs-all  Sat Nov  2  0: 4:12 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 88D5C37B401; Sat,  2 Nov 2002 00:04:10 -0800 (PST)
Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 3FBAB43E6E; Sat,  2 Nov 2002 00:04:05 -0800 (PST)
	(envelope-from ru@whale.sunbay.crimea.ua)
Received: (from ru@localhost)
	by whale.sunbay.crimea.ua (8.11.6/8.11.2) id gA2840b74953;
	Sat, 2 Nov 2002 10:04:00 +0200 (EET)
	(envelope-from ru)
Date: Sat, 2 Nov 2002 10:04:00 +0200
From: Ruslan Ermilov <ru@FreeBSD.org>
To: "John W. De Boskey" <jwd@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/release Makefile
Message-ID: <20021102080400.GB17714@sunbay.com>
References: <200211020600.gA2606qn094387@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="z6Eq5LdranGa6ru8"
Content-Disposition: inline
In-Reply-To: <200211020600.gA2606qn094387@repoman.freebsd.org>
User-Agent: Mutt/1.3.99i
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG


--z6Eq5LdranGa6ru8
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Nov 01, 2002 at 10:00:06PM -0800, John W. De Boskey wrote:
> jwd         2002/11/01 22:00:06 PST
>=20
>   Modified files:
>     release              Makefile=20
>   Log:
>   Add CVSARGS for cvs arguments (vs. cvs subcommand arguments).
>   Allow the cvs command to be prefixed by using CVSPREFIX.
>  =20
>   Revision  Changes    Path
>   1.718     +21 -14    src/release/Makefile
>=20
May I suggest that you replace

${CVSPREFIX} cvs -R ${CVSARGS}

with

${CVS} defaulting to ``cvs -R''?

This resembles the similar feature in Makefile.inc1 better.
And otherwise, this is becoming overcomplicated IMO.  This
also needs to be documented in release(7) manpage.


Cheers,
--=20
Ruslan Ermilov		Sysadmin and DBA,
ru@sunbay.com		Sunbay Software AG,
ru@FreeBSD.org		FreeBSD committer,
+380.652.512.251	Simferopol, Ukraine

http://www.FreeBSD.org	The Power To Serve
http://www.oracle.com	Enabling The Information Age

--z6Eq5LdranGa6ru8
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (FreeBSD)

iD8DBQE9w4bwUkv4P6juNwoRAi99AJsFCBOscsX6d17wlUEU24xXE7m8jgCfevV9
hhiLV+7qGAGGYDPQH3WkenE=
=NWuc
-----END PGP SIGNATURE-----

--z6Eq5LdranGa6ru8--

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message