From nobody Sun Aug 24 14:38:58 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4c8xPv23PYz65XFr; Sun, 24 Aug 2025 14:38:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4c8xPt68xwz3Wqf; Sun, 24 Aug 2025 14:38:58 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1756046338; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9Mw3yIg6+bRtJcx7tJ0GoJeO3+Y4lbfevdkceXTUXg0=; b=ZsD9lgFESVSEAQdD8o5UccMfynQh3H1Un3CC+MU+dvG0KVPuJKXleB7SELDHRGcdv478Qs RQzGwhHEo+EscheWwa3ob+nbHj5SnxQiE/eXYD1baiZ3M8c+H0Va6ptYUoAkxwoOoOoW8z QmwOUobD8ptXmjll5ikxqwYjH0i1LNCBAIWotN1M0Xa53/RJvy+4d5TLrup0y7W75IuqIh D+h2I5olPl29OyQ7cVDoIZqlsT/yRtMaAO/GrQqXx8ALb9js8DhpDQXPGm8xhHfSvyg0TD +Sn0X0zWK+Dzmxnm4urDdpTeJ7vu8rPMfmyUarkZc1QkwsMtdYCB+4mnJtthUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1756046338; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9Mw3yIg6+bRtJcx7tJ0GoJeO3+Y4lbfevdkceXTUXg0=; b=gYNPGiz3weEM2zwR82Vt8Ze2CZUrECuorQHmmmcPeTsdBfJcyj5rmlXgophd8LX7nfzmDk Gz0UoAi01JAB6vQTohmqT8OTpELPefU6tVojWNjmO+iHM8AZ+to+U5ZqAWNDTIc4YXkIZL xLWghhI+s/rkK8HPp575CGT2cIDXOenemX3JUCvGgZeIA156gUXSHFH+MjfbtoIoeqJ6LV Wi1yy3B3cVd4ZGZJs0qNqZUv4GIIMNoDVfgjZVL5jQOuRWAicIRy1C0lYykQ6wB4w99qvC Obn1mAbgZClMLJd8qvpGOzXr8P8oRpUD0fiCd+qDcB3ZS2RKCcvamJmL63j9Zg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1756046338; a=rsa-sha256; cv=none; b=IZiZAZWPb2XWc1ZOTVzpOVy/JYDhHw0SsQG29E3zWdPPsktTXcnOYgwzuZlmyUiOVCBwE6 vFyxFE7/xJc2X0J3SKvGFmDk9ex5QtSzYQR6kI8KQsOsO0QkVWvF71Os9cU7FgLKA5WPsj ShY+7WcHgJu0xmajOtoTlFVFp2pGmGndq+SN1pc2N2qcVQu6sQpRpa7u49OOe2p+N6j4pg i76JifuMO+TnDp3i+0gy3l9CsykExslA/WTWS63+GtzecVZ/4scPWDbgvgFooAqrgk4y4o V+61wDf2QlSd+KY0LmCFRpr33nWw6gme5t33MT23edrJGO6doD/TckD2ynjKfA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4c8xPt5hPfz1645; Sun, 24 Aug 2025 14:38:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 57OEcwDX040710; Sun, 24 Aug 2025 14:38:58 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 57OEcw1v040707; Sun, 24 Aug 2025 14:38:58 GMT (envelope-from git) Date: Sun, 24 Aug 2025 14:38:58 GMT Message-Id: <202508241438.57OEcw1v040707@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: "Bjoern A. Zeeb" Subject: git: b1e67b1a74d3 - main - LinuxKPI: 802.11: improve ieee80211_request_smps() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b1e67b1a74d33e7a26e53886750a48f070a47226 Auto-Submitted: auto-generated The branch main has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=b1e67b1a74d33e7a26e53886750a48f070a47226 commit b1e67b1a74d33e7a26e53886750a48f070a47226 Author: Bjoern A. Zeeb AuthorDate: 2025-08-24 08:28:30 +0000 Commit: Bjoern A. Zeeb CommitDate: 2025-08-24 10:26:44 +0000 LinuxKPI: 802.11: improve ieee80211_request_smps() Adjust logging from TODO() to IMPROVE() now that we can use fmt strings there too. Make sure we are not getting unsuported values to print. Also for non-station mode simply return. Sponsored by: The FreeBSD Foundation MFC after: 3 days --- sys/compat/linuxkpi/common/include/net/mac80211.h | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/sys/compat/linuxkpi/common/include/net/mac80211.h b/sys/compat/linuxkpi/common/include/net/mac80211.h index c667ddea1085..19f7bcff29dc 100644 --- a/sys/compat/linuxkpi/common/include/net/mac80211.h +++ b/sys/compat/linuxkpi/common/include/net/mac80211.h @@ -1741,12 +1741,15 @@ ieee80211_request_smps(struct ieee80211_vif *vif, u_int link_id, "SMPS_STATIC", "SMPS_DYNAMIC", "SMPS_AUTOMATIC", - "SMPS_NUM_MODES" }; - if (linuxkpi_debug_80211 & D80211_TODO) - printf("%s:%d: XXX LKPI80211 TODO smps %d %s\n", - __func__, __LINE__, smps, smps_mode_name[smps]); + if (vif->type != NL80211_IFTYPE_STATION) + return; + + if (smps >= nitems(smps_mode_name)) + panic("%s: unsupported smps value: %d\n", __func__, smps); + + IMPROVE("XXX LKPI80211 TODO smps %d %s\n", smps, smps_mode_name[smps]); } static __inline void