Date: Thu, 21 Apr 2016 10:52:37 -0700 From: Juli Mallett <juli@clockworksquid.com> To: Hans Petter Selasky <hps@selasky.org> Cc: Ngie Cooper <yaneurabeya@gmail.com>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r298412 - head/sys/ofed/drivers/infiniband/core Message-ID: <CACVs6=-iKVChHOiJjbn%2BOft-uUE603rwnfnk=fhZFtRVW0mfHg@mail.gmail.com> In-Reply-To: <57190C47.8070106@selasky.org> References: <201604211604.u3LG4wmT035874@repo.freebsd.org> <CAGHfRMC3UW6dAy6cW%2B8EJ1f=RxQy%2BTJV1dvHozGhaSmUWqAdNA@mail.gmail.com> <57190C47.8070106@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Apr 21, 2016 at 10:22 AM, Hans Petter Selasky <hps@selasky.org> wrote: > On 04/21/16 19:12, Ngie Cooper wrote: >> >> Please put the "deadcode" back. It will crash now if it's given an >> invalid address family (or none are configured in the kernel) when it >> tries to do the memcpy below. > > > If you look a few lines up in the file, not the patch, you'll see that there > already is a switch case which catches this. > > OK? Then there should be an assertion or something else of that sort (I forget if we have a __builtin_unreachable()-alike macro in the kernel; the lint(1)y NOTREACHED isn't as nice as actual code) so that it is apparent to a human that this case cannot be reached. The presence of a do-nothing default case is not typically indicative of unreachable code.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACVs6=-iKVChHOiJjbn%2BOft-uUE603rwnfnk=fhZFtRVW0mfHg>