Date: Fri, 28 Dec 2012 16:46:33 -0800 From: Greg Lewis <glewis@eyesbeyond.com> To: Eitan Adler <lists@eitanadler.com> Cc: David Demelier <demelier.david@gmail.com>, java@freebsd.org, freebsd-ports@freebsd.org, Ronald Klop <ronald-freebsd8@klop.yi.org> Subject: Re: java/openjdk6 fails to build.. Message-ID: <20121229004633.GA90854@misty.eyesbeyond.com> In-Reply-To: <CAF6rxgmacHpD1vFuTk3p71wwhhXVesmsd%2BoanwG=%2Bd4aipsOzw@mail.gmail.com> References: <CAO%2BPfDdqAYamV5xW8dKCFX=GBYthmCdkmxwNa1OW%2Bas9zU5BLA@mail.gmail.com> <op.wpojwpjs8527sy@212-182-167-131.ip.telfort.nl> <CAF6rxgk0QVVB7QXTD5n5MwAqbMtMteTMYx=PV=J1ayDLQU6QOw@mail.gmail.com> <CAO%2BPfDdDVhsb%2BDY4g%2BWwwWASeshcerVxFrOB9_HaMp=zcdtvGg@mail.gmail.com> <CAF6rxg=YO6nxf4oAQLpB2=M1EJDLVr0TBjCvPHowHkgSqw0Uuw@mail.gmail.com> <20121228202457.GA80033@misty.eyesbeyond.com> <CAF6rxgmacHpD1vFuTk3p71wwhhXVesmsd%2BoanwG=%2Bd4aipsOzw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Dec 28, 2012 at 03:49:56PM -0500, Eitan Adler wrote: > On 28 December 2012 15:24, Greg Lewis <glewis@eyesbeyond.com> wrote: > > On Fri, Dec 21, 2012 at 07:27:22PM -0500, Eitan Adler wrote: > >> On 21 December 2012 19:16, David Demelier <demelier.david@gmail.com> wrote: > >> > Yes, I wanted to answser, but the man says that MAKE_JOBS are disabled by > >> > default, I tried to build with MAKE_JOBS=1 and it works, the problem did > >> > appear when MAKE_JOBS=6 was set. Can you reproduce the issue? > >> > >> I want to mark this MAKE_JOBS_UNSAFE=yes and remove the current hack > >> Any objection from java@ ? > >> > >> > I had MAKE_JOBS=6 in my /etc/make.conf instead of MAKE_JOBS_NUMBER though > >> > >> Exactly. MAKE_JOBS is not user-settable. MAKE_JOBS_NUMBER is. IMHO > >> MAKE_JOBS should start with an _. > > > > I think that's right. I have no objection. I think whats in openjdk7 > > is closer to what it should be. > > What is in openjdk7 seems bogus and it isn't clear why it is there: > MAKE_JOBS_UNSAFE= yes > is defined implying that MAKE_JOBS should always be 1 (and -j never set) > but it does some weird things with the global variables > MAKE_JOBS_NUMBER and DISABLE_MAKE_JOBS. > > Can the generic handling in b.p.m not work? > > IMHO MAKE_JOBS_SAFE=yes should be defined and either b.p.m or b.java.m > should be handling the special build code. MAKE_JOBS_SAFE=yes should not be defined since neither of the ports are safe for multiple make jobs. As an exception, the HotSpot portion of the build is and that is what the other portion handles. -- Greg Lewis Email : glewis@eyesbeyond.com Eyes Beyond Web : http://www.eyesbeyond.com Information Technology FreeBSD : glewis@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121229004633.GA90854>