Skip site navigation (1)Skip section navigation (2) 
Date:      Wed, 1 Feb 2017 05:25:15 +0000 (UTC)
From:      Jan Beich <jbeich@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r432969 - in head/multimedia/vdr-plugin-vdrmanager: . files
Message-ID:  <201702010525.v115PFBR086704@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: jbeich
Date: Wed Feb  1 05:25:15 2017
New Revision: 432969
URL: https://svnweb.freebsd.org/changeset/ports/432969

Log:
  multimedia/vdr-plugin-vdrmanager: unbreak with clang 4.0
  
  sock.cpp:23:13: error: ordered comparison between pointer and zero ('int (*)(int, int, int)' and 'int')
          if (socket >= 0) {
              ~~~~~~ ^  ~
  
  PR:		216217
  Reported by:	antoine (via exp-run)
  Obtained from:	upstream

Added:
  head/multimedia/vdr-plugin-vdrmanager/files/patch-sock.cpp   (contents, props changed)
Modified:
  head/multimedia/vdr-plugin-vdrmanager/Makefile   (contents, props changed)

Modified: head/multimedia/vdr-plugin-vdrmanager/Makefile
==============================================================================
--- head/multimedia/vdr-plugin-vdrmanager/Makefile	Wed Feb  1 05:25:02 2017	(r432968)
+++ head/multimedia/vdr-plugin-vdrmanager/Makefile	Wed Feb  1 05:25:15 2017	(r432969)
@@ -3,7 +3,7 @@
 
 PORTNAME=	vdr-plugin-vdrmanager
 PORTVERSION=	0.6
-PORTREVISION=	3
+PORTREVISION=	4
 CATEGORIES=	multimedia
 MASTER_SITES=	http://projects.vdr-developer.org/attachments/download/828/
 DISTNAME=	${PORTNAME:S/-plugin//}-${PORTVERSION}

Added: head/multimedia/vdr-plugin-vdrmanager/files/patch-sock.cpp
==============================================================================
--- /dev/null	00:00:00 1970	(empty, because file is newly added)
+++ head/multimedia/vdr-plugin-vdrmanager/files/patch-sock.cpp	Wed Feb  1 05:25:15 2017	(r432969)
@@ -0,0 +1,17 @@
+From 333d83324710bbdef6f6feea38a9dadc3c01b959 Mon Sep 17 00:00:00 2001
+From: bju <bju@maxi.fritz.box>
+Date: Tue, 24 Jan 2012 23:06:34 +0100
+Subject: Close() has used socket (method pointer) and not sock (variable) to
+ check if close() should be called.
+
+--- a/sock.cpp.orig	2011-12-28 15:11:48 UTC
++++ b/sock.cpp
+@@ -20,7 +20,7 @@ cVdrmanagerSocket::~cVdrmanagerSocket() 
+ }
+ 
+ void cVdrmanagerSocket::Close() {
+-	if (socket >= 0) {
++	if (sock >= 0) {
+ 		close(sock);
+ 		sock = -1;
+ 	}

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201702010525.v115PFBR086704>