From owner-freebsd-hackers@FreeBSD.ORG  Fri Apr  8 12:57:19 2005
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id B3F9016A4CE; Fri,  8 Apr 2005 12:57:19 +0000 (GMT)
Received: from mp2.macomnet.net (mp2.macomnet.net [195.128.64.6])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id D0C3C43D1F; Fri,  8 Apr 2005 12:57:18 +0000 (GMT)
	(envelope-from maxim@macomnet.ru)
Received-SPF: pass (mp2.macomnet.net: domain of maxim@macomnet.ru designates
	127.0.0.1 as permitted sender) receiver=mp2.macomnet.net; client_ip=127.0.0.1;
	envelope-from=maxim@macomnet.ru;
Received: from localhost (localhost [127.0.0.1])
	by mp2.macomnet.net (8.12.11/8.12.11) with ESMTP id j38CvGiE057592;
	Fri, 8 Apr 2005 16:57:17 +0400 (MSD)
	(envelope-from maxim@macomnet.ru)
Date: Fri, 8 Apr 2005 16:57:16 +0400 (MSD)
From: Maxim Konovalov <maxim@macomnet.ru>
To: Vijay.Singh@nokia.com
In-Reply-To: <20050324043742.C47410@odysseus.silby.com>
Message-ID: <20050408165616.F57581@mp2.macomnet.net>
References: <E40595640FD457418D8F9005C2BEC8496456D4@mvebe001.americas.nokia.com>
	<20050324043742.C47410@odysseus.silby.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: freebsd-hackers@freebsd.org
cc: andre@freebsd.org
Subject: Re: ip_reass() - possibly incorrect goto
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Apr 2005 12:57:19 -0000

On Thu, 24 Mar 2005, 04:46-0600, Mike Silbersack wrote:

>
> On Wed, 23 Mar 2005, Maxim Konovalov wrote:
>
> > On Tue, 22 Mar 2005, 12:08-0800, Vijay.Singh@nokia.com wrote:
> >
> > > Hi hackers, I am looking at the ip_reass() routine. In case of the
> > > 1st fragment we create the reassembly queue. After the queue has
> > > been inserted in the hash bucket, the if () code does a " goto
> > > inserted". Should this be changed to "goto done" instead? Any code
> > > that is executed for the 1st fragment, like frag per packet limiting
> > > and complete reassembly are not valid. Am I mistaken?
> >
> > Yep, it seems you are right.  The second micro optimization - drop the
> > fragment early if maxfragsperpacket == 0.
> >
> > Andre, Mike, what do you think?
>
> Looks good to me.  Please tell us if you come up with any more optimizations
> for the reassembly code, Vijay.
[...]

Committed to HEAD.  Thanks, Vijay!

-- 
Maxim Konovalov