From owner-svn-src-head@freebsd.org Fri Dec 4 17:57:49 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 213C9A4129F; Fri, 4 Dec 2015 17:57:49 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 70CFB135D; Fri, 4 Dec 2015 17:57:48 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id tB4HvbOY057962 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Fri, 4 Dec 2015 19:57:38 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua tB4HvbOY057962 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id tB4HvbRr057961; Fri, 4 Dec 2015 19:57:37 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 4 Dec 2015 19:57:37 +0200 From: Konstantin Belousov To: Hans Petter Selasky Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r291699 - in head/sys: modules/mlxen ofed/drivers/net/mlx4 Message-ID: <20151204175737.GA2202@kib.kiev.ua> References: <201512031456.tB3EuHVs030967@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201512031456.tB3EuHVs030967@repo.freebsd.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Dec 2015 17:57:49 -0000 On Thu, Dec 03, 2015 at 02:56:17PM +0000, Hans Petter Selasky wrote: > Author: hselasky > Date: Thu Dec 3 14:56:17 2015 > New Revision: 291699 > URL: https://svnweb.freebsd.org/changeset/base/291699 > > Log: > Convert the mlxen driver to use the BUSDMA(9) APIs instead of > vtophys() when loading mbufs for transmission and reception. While at > it all pointer arithmetic and cast qualifier issues were fixed, mostly > related to transmission and reception. > > MFC after: 1 week > Sponsored by: Mellanox Technologies > Differential Revision: https://reviews.freebsd.org/D4284 > > Modified: > head/sys/modules/mlxen/Makefile > head/sys/ofed/drivers/net/mlx4/en_netdev.c > head/sys/ofed/drivers/net/mlx4/en_rx.c > head/sys/ofed/drivers/net/mlx4/en_tx.c > head/sys/ofed/drivers/net/mlx4/mlx4_en.h > > Modified: head/sys/modules/mlxen/Makefile > ============================================================================== > --- head/sys/modules/mlxen/Makefile Thu Dec 3 14:38:55 2015 (r291698) > +++ head/sys/modules/mlxen/Makefile Thu Dec 3 14:56:17 2015 (r291699) > @@ -11,5 +11,3 @@ CFLAGS+= -I${.CURDIR}/../../ofed/include > CFLAGS+= -I${.CURDIR}/../../compat/linuxkpi/common/include > > .include > - > -CFLAGS+= -Wno-cast-qual -Wno-pointer-arith I did not checked to definitely blame this commit, but I do get the following error from the i386 LINT build: In file included from /scratch/tmp/kib/src/sys/modules/mlxen/../../ofed/drivers/ net/mlx4/en_cq.c:34: In file included from /scratch/tmp/kib/src/sys/modules/mlxen/../../ofed/include/ linux/mlx4/cq.h:39: /scratch/tmp/kib/src/sys/modules/mlxen/../../ofed/include/linux/mlx4/doorbell.h: 80:42: error: arithmetic on a pointer to void is a GNU extension [-Werror,-Wpoin ter-arith] __raw_writel((__force u32) val[1], dest + 4); ~~~~ ^ 1 error generated.