From owner-cvs-all@FreeBSD.ORG Sat Apr 8 22:37:49 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0A61416A400; Sat, 8 Apr 2006 22:37:49 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id CDD9243D46; Sat, 8 Apr 2006 22:37:48 +0000 (GMT) (envelope-from bz@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k38MbmCG075444; Sat, 8 Apr 2006 22:37:48 GMT (envelope-from bz@repoman.freebsd.org) Received: (from bz@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k38MbmJw075443; Sat, 8 Apr 2006 22:37:48 GMT (envelope-from bz) Message-Id: <200604082237.k38MbmJw075443@repoman.freebsd.org> From: "Bjoern A. Zeeb" Date: Sat, 8 Apr 2006 22:37:48 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_5 Cc: Subject: cvs commit: src/sys/netipsec xform.h xform_ipip.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Apr 2006 22:37:49 -0000 bz 2006-04-08 22:37:48 UTC FreeBSD src repository Modified files: (Branch: RELENG_5) sys/netipsec xform.h xform_ipip.c Log: MFC: rev. 1.3 src/sys/netipsec/xform.h, rev. 1.12 src/sys/netipsec/xform_ipip.c Fix more stack corruptions on amd64. Vararg functions have a different calling convention than regular functions on amd64. Casting a varag function to a regular one to match the function pointer declaration will hide the varargs from the caller and we will end up with an incorrectly setup stack. Entirely remove the varargs from these functions and change the functions to match the declaration of the function pointers. Remove the now unnecessary casts. Also change static struct ipprotosw[] to two independent protosw/ip6protosw definitions to remove an unnecessary cast. PR: amd64/95008 Submitted by: Mats Palmgren Approved by: re (scottl) Revision Changes Path 1.1.10.2 +1 -1 src/sys/netipsec/xform.h 1.9.2.3 +10 -18 src/sys/netipsec/xform_ipip.c