From owner-p4-projects@FreeBSD.ORG  Sat Nov  4 03:01:28 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 504A516A4D0; Sat,  4 Nov 2006 03:01:28 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 94EA016A494
	for <perforce@freebsd.org>; Sat,  4 Nov 2006 03:01:27 +0000 (UTC)
	(envelope-from jb@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3FDCE43D5C
	for <perforce@freebsd.org>; Sat,  4 Nov 2006 03:01:27 +0000 (GMT)
	(envelope-from jb@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kA431QBe068218
	for <perforce@freebsd.org>; Sat, 4 Nov 2006 03:01:26 GMT
	(envelope-from jb@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kA431QbO068214
	for perforce@freebsd.org; Sat, 4 Nov 2006 03:01:26 GMT
	(envelope-from jb@freebsd.org)
Date: Sat, 4 Nov 2006 03:01:26 GMT
Message-Id: <200611040301.kA431QbO068214@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	jb@freebsd.org using -f
From: John Birrell <jb@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 109208 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 04 Nov 2006 03:01:28 -0000

http://perforce.freebsd.org/chv.cgi?CH=109208

Change 109208 by jb@jb_freebsd8 on 2006/11/04 03:00:41

	Fix the argument checking.

Affected files ...

.. //depot/projects/dtrace/src/lib/libelf/gelf_getshdr.c#4 edit

Differences ...

==== //depot/projects/dtrace/src/lib/libelf/gelf_getshdr.c#4 (text+ko) ====

@@ -89,7 +89,7 @@
 	Elf32_Shdr *sh32;
 
 	if (s == NULL || d == NULL ||
-	    (e = s->s_elf) || e->e_kind != ELF_K_ELF) {
+	    (e = s->s_elf) == NULL || e->e_kind != ELF_K_ELF) {
 		LIBELF_SET_ERROR(ARGUMENT, 0);
 		return (NULL);
 	}