From owner-svn-src-head@freebsd.org Sat Feb 11 14:38:00 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C1ED0CDAB70 for ; Sat, 11 Feb 2017 14:38:00 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm2-vm5.bullet.mail.ne1.yahoo.com (nm2-vm5.bullet.mail.ne1.yahoo.com [98.138.91.224]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8CB5E1987 for ; Sat, 11 Feb 2017 14:38:00 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1486823872; bh=pmwmhvHllt2wW4PZHsbNcfXWuEwSVLkjQHVUudm6M5Y=; h=Subject:To:References:From:Date:In-Reply-To:From:Subject; b=R4JlBdpzl8Puo9twrF1vSVwCO3JUL2BvDVAZugy4ryTdgriLnzo2Dq/pn2Caralv43CtT2huTn3ojw0PoWtbm0XXvWqZhv4tgEogH1P8IbDKbSJN80dBsT4+biPZPcD/eGAMZQrNJuEe/0VJNWBIgf0T35gVZKalfmf1epBWckUJaT/FSVx3K8lKbktTEnB/PcC9LnSDsRG2EdNORgd9GO3BNtjfPjkgOn6/kIfbnQlvu5+0AaPLBQuWoMizZyznw8Kash5Ps5suvtZg9+7nzW0MKg07oHCvbrOvcb2Ss4BGR+9xX20/UQSQHE30T76uTVgAfVBZcUhECkRBhQuK1Q== Received: from [98.138.101.128] by nm2.bullet.mail.ne1.yahoo.com with NNFMP; 11 Feb 2017 14:37:52 -0000 Received: from [98.138.104.113] by tm16.bullet.mail.ne1.yahoo.com with NNFMP; 11 Feb 2017 14:37:52 -0000 Received: from [127.0.0.1] by smtp222.mail.ne1.yahoo.com with NNFMP; 11 Feb 2017 14:37:52 -0000 X-Yahoo-Newman-Id: 937608.1512.bm@smtp222.mail.ne1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: iuNIW4UVM1mYVOp1NnniA_IPVcR7FGBfh.flO4DqchiBtn6 qgjkqBq1v8.OoawL5Y8zd4yVoYuK7A4R.U5kmkYPIlL05wq27k.za_6QiBkR fao4o.L0Fj4a430UlhuUB7tQhXxOlzL7XRbvp.t8A1j6eMhrcJ9afiTsAK3f nFMihp835KUkTwpEelUB8Pmof2wYVgl4PV3R79sYKXL3vnzb5VrNU4X5I093 UuLZbFTEAvxK3h_gXXEz_.4.tCD54ZC7w4I3YM5FPAFduI5gmtqEOlO5.o7j s_39XDCcFK6OR565QZEeAOT4VRSNNn3DJYp7k_iey3D_a.xsaqNjcvSWBgv6 pfAh0dJPoVVj0Fsj6BXl9fN7.uB.jV0pwKOQIqpAtBTXLj1Vz6hsaiZ3lGZV yR83InuWiSfbOieZFx2GaYes00I7YrwNadE7jAuMxxJ4ytUWAK9Jz.EKIPS4 VKiBb33kaUxlYBBAyuHujkrfG0H.XZNj1iqWTFUXjfKx5.o1sH8w45U.HK1m Bp7CqMryP3Pyf22rC7iKOHj3XZJaqDyhK1lKggbHsVBJqwMw- X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Subject: Re: svn commit: r312988 - in head/sys: compat/cloudabi compat/linux kern sys To: John Baldwin , Gleb Smirnoff , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org References: <201701301257.v0UCvNrK065993@repo.freebsd.org> <3349880.lYJPXOWCO7@ralph.baldwin.cx> <20170201182337.GG3334@FreeBSD.org> <148601396.h8ndg2hV6R@ralph.baldwin.cx> <20170211125548.GB3574@brick> From: Pedro Giffuni Message-ID: <7cd316b7-acd1-c2ac-2ea0-1e81635aba91@FreeBSD.org> Date: Sat, 11 Feb 2017 09:40:19 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20170211125548.GB3574@brick> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Feb 2017 14:38:00 -0000 On 2/11/2017 7:55 AM, Edward Tomasz Napierala wrote: > On 0201T1236, John Baldwin wrote: >> On Wednesday, February 01, 2017 10:23:37 AM Gleb Smirnoff wrote: >>> On Tue, Jan 31, 2017 at 02:13:36PM -0800, John Baldwin wrote: >>> J> On Monday, January 30, 2017 12:57:23 PM Edward Tomasz Napierala wrote: >>> J> > Author: trasz >>> J> > Date: Mon Jan 30 12:57:22 2017 >>> J> > New Revision: 312988 >>> J> > URL: https://svnweb.freebsd.org/changeset/base/312988 >>> J> > >>> J> > Log: >>> J> > Add kern_listen(), kern_shutdown(), and kern_socket(), and use them >>> J> > instead of their sys_*() counterparts in various compats. The svr4 >>> J> > is left untouched, because there's no point. >>> J> >>> J> Note that you can compile test svr4 since it is still in the tree. >>> J> If we want to remove svr4, then we should remove it. However, we >>> J> should maintain code that is in the tree if it is still there. >>> >>> All we can do right now is maintain it as compilable. My example with >>> COMPAT_OLDSOCK shows that SVR4 simply doesn't work as kld, and nobody >>> complains. >>> >>> Okay, what if I say on freebsd-arch/freebsd-current that I am going >>> to remove it and wait for any objections for a month, and then do it? >> I would rather remove it than start skipping it in tree sweeps. We should >> strive to maintain code that is in our tree. If you can't get things tested, >> then we are better off removing the code instead of having it rot in the >> tree (cf the discussion on old ISA drivers). > On one hand you're right. On the other - in this particular case including > svr4 (which I have no way of testing) in this sweep could break it, while > not touching it couldn't, as the old method continues to work. > > Removing it is not a bad idea, though. Gleb, would you? > > FWIW, the SVR4 emulator was never completely ported from NetBSD and no one seems to have any interest in bringing it to amd64. I'd say kill it, if someone ever needs it back we have subversion. Pedro.