From owner-freebsd-current  Tue Aug  3 20: 8: 3 1999
Delivered-To: freebsd-current@freebsd.org
Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.26.10.9])
	by hub.freebsd.org (Postfix) with ESMTP
	id F3558151C6; Tue,  3 Aug 1999 20:07:58 -0700 (PDT)
	(envelope-from bde@godzilla.zeta.org.au)
Received: (from bde@localhost)
	by godzilla.zeta.org.au (8.8.7/8.8.7) id NAA02945;
	Wed, 4 Aug 1999 13:06:56 +1000
Date: Wed, 4 Aug 1999 13:06:56 +1000
From: Bruce Evans <bde@zeta.org.au>
Message-Id: <199908040306.NAA02945@godzilla.zeta.org.au>
To: archie@whistle.com
Subject: Re: Panic plus advice needed
Cc: bde@FreeBSD.ORG, current@FreeBSD.ORG, dwmalone@maths.tcd.ie,
	grog@lemis.com
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

>> > One reason adding -g doesn't work at times is if the kernel is
>> > recompiled by a person with a different length username. vers.c
>> > is produced with a string which is a different length which screws
>> > up the offsets.
>> > 
>> > Maybe newvers.sh should pad usernames to the legal max? Maybe we should
>> > warn people to touch vers.c after editing the Makefile?
>> 
>> That would be really helpful to us actually and I imagine lots of people.
>> In fact, you don't need to pad the username, just add the right number of
>> zeroes to the end of the string, eg.
>
>Any objections to the patch below?

Yes.  It bloats the kernel and only fixed one cause of the problem.

>And a related question: why not define ostype[], et.al. as "const" ?

It would cause a cast-qual warning when SYSCTL_STRING() casts away the
"const".  Casting away the "const" is OK for the CTLFLG_RD case but not
for the CTLFLAG_RW case.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message