From owner-freebsd-fs@FreeBSD.ORG Fri Nov 7 09:48:16 2014 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 97EAE202 for ; Fri, 7 Nov 2014 09:48:16 +0000 (UTC) Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 272D46AB for ; Fri, 7 Nov 2014 09:48:15 +0000 (UTC) Received: by mail-wi0-f170.google.com with SMTP id r20so3799397wiv.1 for ; Fri, 07 Nov 2014 01:48:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type; bh=nMYsiNmyvMmvdwYxBmrBB726xP5+jfw4aK55eywcgxA=; b=IqNjCF5YTjcNWCt2jwGbKR/F5dmzy7rWswLHeC+GaHT1xg7YDedZO7M7/TdXk0POOw Ew3fbkulV/b0nyrdE0Vvp7sPlTJ67E8tOWI8ciS9LgxS9GGAZjCabAOFV4dTC+QtRySr Ii3lltPnad/1j0mpJ0LoJQk9BO14OFhOUb/H5I9yTGTnAjBggoYAvdyV9M5CiBLWzQhT mMKLsqBe13ednwMBVgjcNwVOtyBWb9z0S+7VbiC2xEoR7SQ2Lj3W5NF0U74qWq3ZPgQg /vlhWxv2GJdq7roXJOCXcsN927Z1sL/KtK1SR5l1wfrxwjVHVrR3w1hWKCsQwEm+iwkr bmjQ== X-Gm-Message-State: ALoCoQksde3dPXjCo1I0UASkTO9tLsbt08t59081zValPaFS7bBT6WY968yd1Gx0HwAeAIuzFgg9 X-Received: by 10.180.187.44 with SMTP id fp12mr3402714wic.72.1415353693266; Fri, 07 Nov 2014 01:48:13 -0800 (PST) Received: from [10.10.1.68] (82-69-141-170.dsl.in-addr.zen.co.uk. [82.69.141.170]) by mx.google.com with ESMTPSA id hu3sm11103379wjb.17.2014.11.07.01.48.12 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Nov 2014 01:48:12 -0800 (PST) Message-ID: <545C9552.30207@multiplay.co.uk> Date: Fri, 07 Nov 2014 09:48:02 +0000 From: Steven Hartland User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Borja Marcos Subject: Re: ZFS bug: was creating ZIL ignores vfs.zfs.min_auto_ashift, should be ZIL sets improper ashift with AHCI controllers References: <9C91F97841BC4347910F206618BAA3BB9AF327D1@PAIMAIL.pai.local> <545B76EF.6050709@multiplay.co.uk> <21D2A3A9-B6C1-458F-B17F-480251E999AE@sarenet.es> <545BE3E0.4030203@multiplay.co.uk> <757B9039-8DF0-4E6A-A036-82A2143D7F45@sarenet.es> In-Reply-To: <757B9039-8DF0-4E6A-A036-82A2143D7F45@sarenet.es> Content-Type: multipart/mixed; boundary="------------040004010503080103060804" Cc: freebsd-fs@freebsd.org X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Nov 2014 09:48:16 -0000 This is a multi-part message in MIME format. --------------040004010503080103060804 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On 07/11/2014 07:31, Borja Marcos wrote: > snip... > > You are right! > > This time I had not altered min_auto_ashift but I had added a quirk to ata_da.c. So it > correctly used the quirk sector size to adjust ashift. > > Seems the bug should be "improper cache file generation for a pool used for boot". I'll > see if I can run some more tests. > I believe the attached is the correct fix, but I've asked upstream as this test was explicitly added ages ago. Regards Steve --------------040004010503080103060804 Content-Type: text/plain; charset=windows-1252; name="zpool-cache.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="zpool-cache.patch" Index: sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa_config.c =================================================================== --- sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa_config.c (revision 274189) +++ sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa_config.c (working copy) @@ -536,8 +536,7 @@ spa_config_update(spa_t *spa, int what) /* * Update the global config cache to reflect the new mosconfig. */ - if (!spa->spa_is_root) - spa_config_sync(spa, B_FALSE, what != SPA_CONFIG_UPDATE_POOL); + spa_config_sync(spa, B_FALSE, what != SPA_CONFIG_UPDATE_POOL); if (what == SPA_CONFIG_UPDATE_POOL) spa_config_update(spa, SPA_CONFIG_UPDATE_VDEVS); --------------040004010503080103060804--