From owner-cvs-all@FreeBSD.ORG  Fri Sep 23 21:04:02 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 7084F16A41F;
	Fri, 23 Sep 2005 21:04:02 +0000 (GMT)
	(envelope-from csjp@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3995B43D46;
	Fri, 23 Sep 2005 21:04:02 +0000 (GMT)
	(envelope-from csjp@FreeBSD.org)
Received: from freefall.freebsd.org (csjp@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j8NL42kn052330;
	Fri, 23 Sep 2005 21:04:02 GMT
	(envelope-from csjp@freefall.freebsd.org)
Received: (from csjp@localhost)
	by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j8NL423M052329;
	Fri, 23 Sep 2005 21:04:02 GMT (envelope-from csjp)
Date: Fri, 23 Sep 2005 21:04:02 +0000
From: "Christian S.J. Peron" <csjp@FreeBSD.org>
To: Xin LI <delphij@FreeBSD.org>
Message-ID: <20050923210402.GA50245@freefall.freebsd.org>
References: <200509232049.j8NKnvIj024351@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200509232049.j8NKnvIj024351@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.1i
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/ufs/ufs ufs_inode.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Sep 2005 21:04:02 -0000

On Fri, Sep 23, 2005 at 08:49:57PM +0000, Xin LI wrote:
[..]
>   Log:
>   Restore a historical ufs_inactive behavior that has been changed
>   in rev. 1.40 of ufs_inode.c, which allows an inode being truncated
>   even when the filesystem itself is marked RDONLY.  A subsequent
>   call of UFS_TRUNCATE (ffs_truncate) would panic the system as it
>   asserts that it can only be called when the filesystem is mounted
>   read-write (same changeset, rev. 1.74 of sys/ufs/ffs/ffs_inode.c).
>   

Just to make sure that I am understanding you correctly here: You have
restored a behaviour which can result in inode truncation, even on read
only filesystems? Or you removed this behaviour?

-- 
Christian S.J. Peron
csjp@FreeBSD.ORG
FreeBSD Committer
FreeBSD Security Team