From owner-svn-src-all@freebsd.org Thu May 5 08:25:42 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A28F8B2D6EB; Thu, 5 May 2016 08:25:42 +0000 (UTC) (envelope-from julian@freebsd.org) Received: from vps1.elischer.org (vps1.elischer.org [204.109.63.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "vps1.elischer.org", Issuer "CA Cert Signing Authority" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4C5F81482; Thu, 5 May 2016 08:25:42 +0000 (UTC) (envelope-from julian@freebsd.org) Received: from Julian-MBP3.local (ppp121-45-225-151.lns20.per1.internode.on.net [121.45.225.151]) (authenticated bits=0) by vps1.elischer.org (8.15.2/8.15.2) with ESMTPSA id u458PZrn099362 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 5 May 2016 01:25:38 -0700 (PDT) (envelope-from julian@freebsd.org) Subject: Re: svn commit: r299108 - head/sys/sys To: "Ngie Cooper (yaneurabeya)" , John Baldwin References: <201605050251.u452pVSN034598@repo.freebsd.org> <2598444.C6bcyDe9AO@ralph.baldwin.cx> <7993F466-ADCA-4E82-A258-9E2C7BA8896C@gmail.com> Cc: Garrett Cooper , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Julian Elischer Message-ID: Date: Thu, 5 May 2016 16:25:29 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <7993F466-ADCA-4E82-A258-9E2C7BA8896C@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2016 08:25:42 -0000 On 5/05/2016 4:08 PM, Ngie Cooper (yaneurabeya) wrote: >> On May 4, 2016, at 20:17, John Baldwin wrote: >> >> On Thursday, May 05, 2016 02:51:31 AM Garrett Cooper wrote: >>> Author: ngie >>> Date: Thu May 5 02:51:31 2016 >>> New Revision: 299108 >>> URL: https://svnweb.freebsd.org/changeset/base/299108 >>> >>> Log: >>> Revert r299096 >>> >>> The change broke buildworld when building lib/libkvm >>> >>> This change likely needs to be run through a ports -exp run as a sanity >>> check, as it might break downstream consumers. >>> >>> Pointyhat to: adrian >>> Reported by: kargl (confirmed on $work workstation) >>> Sponsored by: EMC / Isilon Storage Division >> 'struct foo *' can be use with a simple forward declare in headers without >> requiring header pollution (and is often done for that reason). device_t >> should be used in any .c files, but headers might need to stick with >> 'struct device *' in a few cases for that reason. I suspect both of these >> fall into that category. > I agree based on the technical point (I didn’t dig into the why, but it makes sense), but this commit wasn’t even compile tested. I would rather figure out what the effects are before reintroducing the change. > If this is being done to address compatibility issues with linuxkpi, I see two paths forward with this (there are probably more..): > 1. Convert everything over to device_t (which bde@ disagrees with), after doing a full tinderbox run and exp- run > 2. Localize the “shim”/typedef to linuxkpi so device_t is used there, or struct device* is used there. > Thoughts? > -Ngie > it seems a bit silly to change out code because there is symbol/type of the same name in Linux. there must be some symbol munging possibility?