From owner-freebsd-current  Fri Mar 20 23:09:18 1998
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id XAA03705
          for freebsd-current-outgoing; Fri, 20 Mar 1998 23:09:18 -0800 (PST)
          (envelope-from owner-freebsd-current@FreeBSD.ORG)
Received: from parkplace.cet.co.jp (parkplace.cet.co.jp [202.32.64.1])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id XAA03700
          for <freebsd-current@FreeBSD.ORG>; Fri, 20 Mar 1998 23:09:16 -0800 (PST)
          (envelope-from michaelh@cet.co.jp)
Received: from localhost (michaelh@localhost) by parkplace.cet.co.jp (8.8.8/CET-v2.2) with SMTP id HAA27076; Sat, 21 Mar 1998 07:05:54 GMT
Date: Sat, 21 Mar 1998 16:05:54 +0900 (JST)
From: Michael Hancock <michaelh@cet.co.jp>
To: Terry Lambert <tlambert@primenet.com>
cc: phk@critter.freebsd.dk, freebsd-current@FreeBSD.ORG
Subject: Re: 4 WILLRELE's to bite the dust
In-Reply-To: <199803201906.MAA17435@usr05.primenet.com>
Message-ID: <Pine.SV4.3.95.980321154950.26993B-100000@parkplace.cet.co.jp>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

On Fri, 20 Mar 1998, Terry Lambert wrote:

> You probably want to get:
> 
> 	http://www.freebsd.org/~terry/testset.txt
> 	http://www.freebsd.org/~terry/testset.tar.gz.uu
> 
> Which is a test toolkit that knows how to detect kernel memory
> leaks over a series of system calls used to exercise various
> code paths.
> 
> The sample implementation looks for namei() path buffer leaks; I
> used it to verify the nameifree() code before I submitted it the
> first time.

I'll take a look.  It's an interesting coincidence that most of the
WILLRELE violations were in the name creation and name management vops. 
Just about every place I corrected a vrele/vput was a also a nameifree() 
screaming to be moved/corrected too. 

I've done the dvp's for 5 name creation ops, vop_create, vop_mkdir,
vop_symlink, vop_link, and vop_mknod; and 1 of 3 name modification ops,
vop_rmdir.  I think I'll press on and do the other 2, and vop_remove and
vop_rename.

Regards,


Mike Hancock


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message