From owner-svn-src-head@FreeBSD.ORG Fri Jun 13 16:57:23 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 22E36935 for ; Fri, 13 Jun 2014 16:57:23 +0000 (UTC) Received: from mail-ie0-f171.google.com (mail-ie0-f171.google.com [209.85.223.171]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DA5F4202F for ; Fri, 13 Jun 2014 16:57:22 +0000 (UTC) Received: by mail-ie0-f171.google.com with SMTP id x19so2728603ier.2 for ; Fri, 13 Jun 2014 09:57:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:content-type:mime-version:subject:from :in-reply-to:date:cc:message-id:references:to; bh=Rs9KIJ4Iud2ef9W+hPxHKJNVTvLyaFad1qnm9ZcWXAA=; b=YHObln84T8vxwx75dtWtl0ZlOb/VFA5i7BseVe1Nxp6dxSaFiTbCIqpl7UYcQE5kPe PILFGEMdIF8mScRGT7IYmZJGLLtkyj96R5HXSMOtuhKjCDrieIkEIXhY2zRq+WLaKQIB Uk02lASszTabMUG4cptLRwnwwfKp/IRXYTdYi0xyKZV9mXL6weY7s6u+n8XuuilkpXTg GnbIdsLfISKmwnOnMOUoSIJina6gSzpIlR54EIamm1Oxlqts3xvi626xrLpG/1mDlCGa Q+FXvIK1KXGGMXVGd9rcVFeyA8AnGxMREvxAE+HmTdg9p6yWG+gl76wtNmV4betmzHmU OWfQ== X-Gm-Message-State: ALoCoQkUeMDpkoJWq3hnGSHRs314qaeZq9jpcySVaRWyE7gxGZMK3eqrOkFO3FBc2yQOmswMPR1g X-Received: by 10.42.58.130 with SMTP id i2mr4815083ich.66.1402678642064; Fri, 13 Jun 2014 09:57:22 -0700 (PDT) Received: from [10.0.0.119] (50-78-194-198-static.hfc.comcastbusiness.net. [50.78.194.198]) by mx.google.com with ESMTPSA id vl10sm4441092igb.16.2014.06.13.09.57.20 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 13 Jun 2014 09:57:21 -0700 (PDT) Sender: Warner Losh Content-Type: multipart/signed; boundary="Apple-Mail=_646603C9-11BA-400F-8CF7-BAE5E0965C3C"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.2\)) Subject: Re: svn commit: r267332 - head/release From: Warner Losh In-Reply-To: <20140613164934.GU1248@hub.FreeBSD.org> Date: Fri, 13 Jun 2014 10:57:22 -0600 Message-Id: <1EB9FE57-8231-439D-8E91-08452AAB2587@bsdimp.com> References: <201406101705.s5AH5gt8007603@svn.freebsd.org> <53973EC7.10306@freebsd.org> <20140613164934.GU1248@hub.FreeBSD.org> To: Glen Barber X-Mailer: Apple Mail (2.1878.2) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Julio Merino , src-committers@freebsd.org, Nathan Whitehorn X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jun 2014 16:57:23 -0000 --Apple-Mail=_646603C9-11BA-400F-8CF7-BAE5E0965C3C Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 On Jun 13, 2014, at 10:49 AM, Glen Barber wrote: > On Fri, Jun 13, 2014 at 10:34:50AM -0600, Warner Losh wrote: >>=20 >> On Jun 10, 2014, at 11:22 AM, Nathan Whitehorn = wrote: >>=20 >>> On 06/10/14 10:05, Julio Merino wrote: >>>> Author: jmmv >>>> Date: Tue Jun 10 17:05:41 2014 >>>> New Revision: 267332 >>>> URL: http://svnweb.freebsd.org/changeset/base/267332 >>>>=20 >>>> Log: >>>> Strip out the test suite from the installation media. >>>> This affects the disc1.iso, dvd1.iso and bootonly.iso files. >>>> Obtained from: gjb >>>>=20 >>>> Modified: >>>> head/release/Makefile >>>>=20 >>>> Modified: head/release/Makefile >>>> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >>>> --- head/release/Makefile Tue Jun 10 17:04:30 2014 = (r267331) >>>> +++ head/release/Makefile Tue Jun 10 17:05:41 2014 = (r267332) >>>> @@ -155,7 +155,7 @@ system: packagesystem >>>> mkdir -p release >>>> cd ${WORLDDIR} && ${IMAKE} installkernel installworld = distribution \ >>>> DESTDIR=3D${.OBJDIR}/release WITHOUT_RESCUE=3D1 = WITHOUT_KERNEL_SYMBOLS=3D1 \ >>>> - WITHOUT_PROFILE=3D1 WITHOUT_SENDMAIL=3D1 WITHOUT_ATF=3D1 = WITHOUT_LIB32=3D1 >>>> + WITHOUT_PROFILE=3D1 WITHOUT_SENDMAIL=3D1 MK_TESTS=3Dno = WITHOUT_LIB32=3D1 >>>> # Copy distfiles >>>=20 >>> Shouldn't this be "WITHOUT_TESTS" or the like? I thought we weren't = supposed to set MK_* at the command line. >>=20 >> We recently started allowing MK_TESTS=3Dno on the command line. In = general, all of those WITHOUT_xxx should become MK_xxx=3Dno in = release/Makefile. Having the MK_xxxx version isolates us further from = (a) the current defaults and (b) config files that turn it to the other = direction. >>=20 >=20 > The WITH*_FOO -> MK_FOO change is on my TODO this weekend. I want to > run at least one full build before committing it. There=92s no rush. What=92s there now works, except in extreme = circumstances. Testing of this stuff is good. It is way too easy to = think a change is a NOP when in fact it breaks something subtle... Warner --Apple-Mail=_646603C9-11BA-400F-8CF7-BAE5E0965C3C Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJTmy1yAAoJEGwc0Sh9sBEAqtwP/RYYWS6PSFVJDDTRKAK90sI6 f9LOaAnEedHslzuqF6zWdWFCblmI1zLWijQVAOpUXUriECHRZyD77dNtm6Q2qy60 8GSL6EUZziWSLVWgf7FvTzW3EoGcHctSzCT7xvk+GYHi8GPHaJWrFyYAo7fSTkOG SLk77UUwbfi2vmpO3u2s6P0mSJwurAnhvJU9zbxliQx3u1h1/EQqwFjnn+IM9rHH oPEaJ/yYGS8IE/d+PVfi51kp7ycMtQdVwt5OM75uz4l0+p72+BadXeZnhEUdkACU y56e1tebkofwhmpij1heTsxucqNkL7BsSOeHp0IC+BZwdmG/vtrbSo/UeR3X3uVv 1QohlmDN9fVKnX3nz9Y08w1ovB0LeFKA2V7rhfnYbW4U0hJEk+sp982teR9y8GkN huzzniM+eF9RQBGzT+AUdiJPPnsWw1GqxJIVDlfc4fZwCmuaCaR6rtrGxDqwmuhK x2ftA43iMub4lVEXSYRr6xISrWg7U9xhyl1gk567EBL/ZlOO0NgbloYiLQNhHV37 Zes/zK5q2vaKHdkqSiA0MpM0YzjojZU9AVP6wiIDlo31sxb/Xc6o287Kk2XtJJXQ u96EEd9on3Nk0x8Qqa3sgT/iNtXKLMH56PM0mgVWLPzc4AM5O0s0iqPlihoBe5SF zyh+xAH2kaUh7eOsrRcz =7Z/R -----END PGP SIGNATURE----- --Apple-Mail=_646603C9-11BA-400F-8CF7-BAE5E0965C3C--