From owner-cvs-all@FreeBSD.ORG Fri Oct 28 15:45:34 2005 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E3F8D16A41F; Fri, 28 Oct 2005 15:45:34 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from mv.twc.weather.com (mv.twc.weather.com [65.212.71.225]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4943743D72; Fri, 28 Oct 2005 15:45:26 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from [10.50.41.234] (Not Verified[10.50.41.234]) by mv.twc.weather.com with NetIQ MailMarshal (v6, 0, 3, 8) id ; Fri, 28 Oct 2005 12:02:13 -0400 From: John Baldwin To: Bill Paul Date: Fri, 28 Oct 2005 10:30:20 -0400 User-Agent: KMail/1.8.2 References: <200510280217.j9S2HfPn056812@repoman.freebsd.org> In-Reply-To: <200510280217.j9S2HfPn056812@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200510281030.22004.jhb@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/pci if_wb.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Oct 2005 15:45:35 -0000 On Thursday 27 October 2005 10:17 pm, Bill Paul wrote: > wpaul 2005-10-28 02:17:41 UTC > > FreeBSD src repository > > Modified files: > sys/pci if_wb.c > Log: > Remove forgotten, no longer needed WB_UNLOCK() from the end wb_ioctl(). > With this change, the driver tests good (at least on i386): > > wb0: port 0xb800-0xb87f mem > 0xe6800000-0xe680007f irq 12 at device 10.0 on pci0 miibus1: on > wb0 > amphy0: on miibus1 > amphy0: 10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, auto > wb0: Ethernet address: 00:00:e8:18:2a:02 > wb0: link state changed to DOWN > wb0: link state changed to UP Thanks for testing this! Sorry about the extra unlock. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org