Date: Mon, 17 Dec 2012 23:47:28 +0200 From: Andriy Gapon <avg@FreeBSD.org> To: Alfred Perlstein <bright@mu.org> Cc: Adrian Chadd <adrian@FreeBSD.org>, src-committers@FreeBSD.org, John Baldwin <jhb@FreeBSD.org>, svn-src-all@FreeBSD.org, Alfred Perlstein <alfred@FreeBSD.org>, Gleb Smirnoff <glebius@FreeBSD.org>, Robert Watson <rwatson@FreeBSD.org>, Navdeep Parhar <np@FreeBSD.org>, Bruce Evans <brde@optusnet.com.au>, svn-src-head@FreeBSD.org Subject: Re: svn commit: r244112 - head/sys/kern Message-ID: <50CF92F0.5020904@FreeBSD.org> In-Reply-To: <50CF8CE7.4020906@mu.org> References: <201212110708.qBB78EWx025288@svn.freebsd.org> <50CBC285.7060307@mu.org> <20121215161414.V1029@besplex.bde.org> <201212171439.27297.jhb@freebsd.org> <50CF8CE7.4020906@mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
on 17/12/2012 23:21 Alfred Perlstein said the following: > This is hard to explain to a customer. > > customer: "So we ran your debug image and got you a panic, here is the > information. So can you tell us what is the problem?" > alfred: "well that is due to XXX other thing that is broken, thanks for helping > us resolve that unrelated problem!" > customer: "i hate you" > alfred: "get in line." But you see, the following is still illogical _to me_. If one believes that all KASSERTs are bogus then one should compile them out and just forget about them. If one believes that at least some KASSERTs are such that the execution should not continue after them, then one should enable all of them and panic on all of them (better safe than sorry). If one is not satisfied with the above choices, then one should meticulously go over all (or at least some) of KASSERTs and make a decision which KASSERTs are bogus, which are true and which should be turned into something else (error checking, warnings, etc). The proposed solution simultaneously enables all KASSERTs, as if all of them were true, and doesn't panic on any KASSERT, as if neither of them is fatal (i.e. they all are bogus to one degree and another). P.S. I am not talking about the status quo because the status quo would be maintained even without the changes in question. -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50CF92F0.5020904>