From owner-p4-projects@FreeBSD.ORG  Mon Apr  2 14:30:43 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id D8AB816A408; Mon,  2 Apr 2007 14:30:42 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id A2AC616A406;
	Mon,  2 Apr 2007 14:30:42 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 4503A13C4BB;
	Mon,  2 Apr 2007 14:30:42 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from fledge.watson.org (fledge.watson.org [209.31.154.41])
	by cyrus.watson.org (Postfix) with ESMTP id 503F947330;
	Mon,  2 Apr 2007 10:30:41 -0400 (EDT)
Date: Mon, 2 Apr 2007 15:30:41 +0100 (BST)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: John Baldwin <jhb@freebsd.org>
In-Reply-To: <200704020915.03985.jhb@freebsd.org>
Message-ID: <20070402152910.A82995@fledge.watson.org>
References: <200704012152.l31LqHuB022635@repoman.freebsd.org>
	<200704020915.03985.jhb@freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: Marcel Moolenaar <marcel@freebsd.org>,
	Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 117140 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Apr 2007 14:30:43 -0000

On Mon, 2 Apr 2007, John Baldwin wrote:

>> @@ -40,6 +40,7 @@
>>  	int		pc_inside_intr;					\
>>  	struct pmap	*pc_curpmap;		/* current pmap */	\
>>  	struct thread   *pc_fputhread;          /* current fpu user */  \
>> +	int		pc_bsp:1;					\
>
> FYI, other places in MI code assume that CPU 0 (pc_cpuid) is the BSP.

I realized the hard way, the other day, that the boot thread itself can 
migrate to another CPU during sysinit processing, once SMP is kicked off.  No 
more KASSERT(curcpu == 0, ()) for me. :-)

Robert N M Watson
Computer Laboratory
University of Cambridge