un 2026 14:09:46 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1781014186; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RjWltcTPsMs62YSt+OthgS2pgJsbr8L2PMxRDIR6eoI=; b=kMEfX4Iebe5Y36Gf4UKgGOkReVyKRsWbH+0itLUgn1nho/7DJSsXWUpnvbu6kESrhKkdT8 jNwkoBGONFaW+eWdoJ2Ig69jjPebOaAmkzkGw95eTQaDxgGWkvkegRirDySEgWT5K9GJdM jXC80sq0p3IZn5S5R0sToW6FANXP5h/YrRc+XvsKKRxGLfjsGc/ey8ICCGZ+iY3h6LFLuA MxTw5tKtfEwqmhR76FmHPOwf/vkDdmMtI9WwYTjZW9mb9ueNlz/w5VSlOeZgKLWtpBUtQa 4wgdYafZSSSLzX3jOxjxWPZ1YsFfm+qVS6ZBeGf6Ks6TRAfnbwRTEMECzmcrbw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1781014186; a=rsa-sha256; cv=none; b=iExyJpsH0YnaN3jBl0yPqwnfll7eNAaXpGnTYDuPQjl2XBCCTW+6b10USR7OBGTav2IWQ7 KFn1YquRdTOEObXvqZWElR1ZNt54DwBM7moIgPBJf3WemgR+WvS+clf52WdPRZIw3BdMHg chFC3vw64btbKDuQzp5a6n/RP5Li6p2jkE+9k0BREr/k7lB6yiqhZJ+6gzV1jDjz3Oy/7z 0Y1K48nPghrCRVY5t1zLtZCt7pjW6jq2pdDfdx+iZbq33yoCy5VyYLzZOevK3GYWSP+VmV th0ZRyrfWzHWMttTFhrPT4DqXL1zDS747hMI6GuWOhU5viPoUi3EdaRoJmEGig== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1781014186; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RjWltcTPsMs62YSt+OthgS2pgJsbr8L2PMxRDIR6eoI=; b=p+g3bBDMC5nKzqHd+P9hZYLM1EHZAidQpDpAxtXJmPahRQDVMDZqvjqkQIgtirhJPFmt5c nJxkyzS8X9tzWq9r5PNSrzSaiYsdPzWm6MeiMugh99J0UemPOIU0Wq+zhPtyDgMcGwQ2NN KUhYwsvFLId4pnwunOgaOuK7j8ZWIwwRMG6Xd79zq8qsuoRF/A8rbBLiQSVdG4nM77Ckof WRBdE/X/HqL7EVtpCXBf8iR5G9jFfncZR5bchSAPe+95FhG3KiCc5Hy+xJVZ0zQcejx3c9 PhGp+dvMwNXF643KXdDBMnP6gtetdY25HPLLYpZ2+iq0HoAf1wQvRwT7x70q6Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gZW4p1TGZzdlM for ; Tue, 09 Jun 2026 14:09:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 4560c by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 09 Jun 2026 14:09:46 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Ed Maste Subject: git: 30d907804d7d - stable/15 - netlink: Check permissions for interface flag changes List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 30d907804d7deb488fd5b43e435bc0f1a7f805a4 Auto-Submitted: auto-generated Date: Tue, 09 Jun 2026 14:09:46 +0000 Message-Id: <6a281eaa.4560c.4ab0d13@gitrepo.freebsd.org> The branch stable/15 has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=30d907804d7deb488fd5b43e435bc0f1a7f805a4 commit 30d907804d7deb488fd5b43e435bc0f1a7f805a4 Author: Ed Maste AuthorDate: 2026-05-29 15:52:03 +0000 Commit: Ed Maste CommitDate: 2026-06-09 13:40:29 +0000 netlink: Check permissions for interface flag changes Reviewed by: pouria, melifaro Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D57332 (cherry picked from commit 96dbc9a8de105065b6b1e55702aa648319176587) --- sys/netlink/route/iface_drivers.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/sys/netlink/route/iface_drivers.c b/sys/netlink/route/iface_drivers.c index d26e92044ff5..79daa4215dba 100644 --- a/sys/netlink/route/iface_drivers.c +++ b/sys/netlink/route/iface_drivers.c @@ -83,6 +83,10 @@ _nl_modify_ifp_generic(struct ifnet *ifp, struct nl_parsed_link *lattrs, if ((lattrs->ifi_change & IFF_UP) != 0 || lattrs->ifi_change == 0) { /* Request to up or down the interface */ + if (!nlp_has_priv(npt->nlp, PRIV_NET_SETIFFLAGS)) { + nlmsg_report_err_msg(npt, "Not enough privileges to set flags"); + return (EPERM); + } if (lattrs->ifi_flags & IFF_UP) if_up(ifp); else @@ -104,7 +108,7 @@ _nl_modify_ifp_generic(struct ifnet *ifp, struct nl_parsed_link *lattrs, } if ((lattrs->ifi_change & IFF_PROMISC) != 0 || - lattrs->ifi_change == 0) + lattrs->ifi_change == 0) { /* * When asking for IFF_PROMISC, set permanent flag instead * (IFF_PPROMISC) as we have no way of doing promiscuity @@ -112,7 +116,12 @@ _nl_modify_ifp_generic(struct ifnet *ifp, struct nl_parsed_link *lattrs, * function either sets or unsets IFF_PROMISC, and ifi_change * is usually set to 0xFFFFFFFF. */ + if (!nlp_has_priv(npt->nlp, PRIV_NET_SETIFFLAGS)) { + nlmsg_report_err_msg(npt, "Not enough privileges to set promisc"); + return (EPERM); + } if_setppromisc(ifp, (lattrs->ifi_flags & IFF_PROMISC) != 0); + } if (lattrs->ifla_address != NULL) { if (!nlp_has_priv(npt->nlp, PRIV_NET_SETIFMAC)) {