From owner-freebsd-current Thu Jan 25 21:04:30 1996 Return-Path: owner-current Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id VAA04845 for current-outgoing; Thu, 25 Jan 1996 21:04:30 -0800 (PST) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.7.3/8.7.3) with SMTP id VAA04839 for ; Thu, 25 Jan 1996 21:04:19 -0800 (PST) Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.9/8.6.9) id QAA19967; Fri, 26 Jan 1996 16:00:31 +1100 Date: Fri, 26 Jan 1996 16:00:31 +1100 From: Bruce Evans Message-Id: <199601260500.QAA19967@godzilla.zeta.org.au> To: pst@shockwave.com, scrappy@ki.net Subject: Re: ether_sprintf bug: possible patch? Cc: current@FreeBSD.ORG Sender: owner-current@FreeBSD.ORG Precedence: bulk >no, just re sup and you should be ok, that patch takes us backwards, %D isn't >used anumore as far as I recall... Re sup in a day or two. %D is too new to be used in all cases where it should be, and ether_sprintf() went away while it was still used. > > /* > * Print additional info when attached > */ > printf("ed%d: address %6D, ", isa_dev->id_unit, > sc->arpcom.ac_enaddr, ":"); > assuming that the following "patch" would work or break something? I'm > going to to try it, but, if I'm missing something due to ignorance... :( > > *** if_ep.c.orig Thu Jan 25 16:28:22 1996 > --- if_ep.c Thu Jan 25 16:28:53 1996 > *************** > *** 408,414 **** > GO_WINDOW(2); > outw(BASE + EP_W2_ADDR_0 + (i * 2), ntohs(p[i])); > } > ! printf(" address %s", ether_sprintf(sc->arpcom.ac_enaddr)); > > /* > * Write IRQ value to board > --- 408,414 ---- > GO_WINDOW(2); > outw(BASE + EP_W2_ADDR_0 + (i * 2), ntohs(p[i])); > } > ! printf(" address %6D", sc->arpcom.ac_enaddr); > > /* > * Write IRQ value to board Not quite. %D takes 2 args. See if_ed.c. Bruce