Date: Wed, 17 Nov 2021 19:51:28 +0100 From: Mathieu Arnold <mat@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Yasuhiro Kimura <yasu@utahime.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: bb8dbe1580ae - main - sysutils/lnav: Fix distinfo Message-ID: <20211117185128.pfww5iqz5prnq54m@aching.in.mat.cc> In-Reply-To: <YZR95khRXDiLkMlD@FreeBSD.org> References: <202111170314.1AH3ETSV087319@gitrepo.freebsd.org> <YZR1/8m59hCb41l1@FreeBSD.org> <20211117.124452.1254944101155682425.yasu@utahime.org> <YZR95khRXDiLkMlD@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--6vkpzccua5n6pt4k Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 17, 2021 at 03:58:30AM +0000, Alexey Dokuchaev wrote: > On Wed, Nov 17, 2021 at 12:44:52PM +0900, Yasuhiro Kimura wrote: > > ... > > PORTVERSION is the version used for the FreeBSD package. It will be > > automatically derived from DISTVERSION to be compatible with > > FreeBSD's package versioning scheme. >=20 > To elaborate: right, so you set DISTVERSION when it's incompatible > with FreeBSD's package versioning scheme. Most of the time it is > compatible, so PORTVERSION should be used instead. I don't know > why this passage had been added to the PHB, I've asked a few times > but never got any meaningful answer. It looks totally backwards > to me, and it causes lots of needless churn on the ports repo. :( I have explained many times, but, I will again. The rule is: 1) use DISTVERSION unless it does not work 2) use PORTVERSION, and maybe set DISTNAME directly What you are saying is: 1) use PORTVERSION unless it does not work 2) use DISTVERSION unless it does not work 3) use PORTVERSION, and set DISTNAME directly The first one is simpler, you don't go back and forth between knobs, you try DISTVERSION, and if it does not produce the correct version, you switch to PORTVERSION. --=20 Mathieu Arnold --6vkpzccua5n6pt4k Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAABCgB9FiEEFD4jMKwz5Ud8Ywu3ecmT/A9inX0FAmGVTy9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDE0 M0UyMzMwQUMzM0U1NDc3QzYzMEJCNzc5Qzk5M0ZDMEY2MjlEN0QACgkQecmT/A9i nX2gBQf+Nvu8EjQdl10JtKKP8C6GrNdp7wWx+1PPZqA13wu24u24LnpA6RvBbs1+ /77tMj+ZegfQFOWo6EOOhkHd6fzfnBSKGcxYdT7xsws3bkukWdiusqBqP1aik03N 3HcOId0Tiht1QbY0qsEeTG4y7aBkfEdsmLfQyf6ioD5NuV7HFGlGH9cACzMU4+X1 3iEbBUXMzRrgAumMng4AjMFIT2okStEEYaRXnW7CMGr5/mrVq78kJZ6ptX7+eJWs d1LDh9bYjxF5I7WxR4d+4fvSZg+gE/k9+/MCW5Si7lmyQJZc7PazTgAhT3SSQdDF DrD33h8EEuBNmUYZFlEOk5MLa5eoNQ== =WWGi -----END PGP SIGNATURE----- --6vkpzccua5n6pt4k--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20211117185128.pfww5iqz5prnq54m>