Date: Thu, 13 Aug 2020 11:32:41 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Adriaan de Groot <adridg@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r496814 - in head: net-im net-im/mtxclient net-im/mtxclient/files security security/olm Message-ID: <20200813113241.GA80435@FreeBSD.org> In-Reply-To: <7526637.L6bdSy1Yio@beastie.bionicmutton.org> References: <201903251040.x2PAegVl021649@repo.freebsd.org> <20200807130322.GA67139@FreeBSD.org> <7526637.L6bdSy1Yio@beastie.bionicmutton.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Aug 13, 2020 at 01:19:02PM +0200, Adriaan de Groot wrote: > On Friday, 7 August 2020 15:03:22 CEST Alexey Dokuchaev wrote: > > On Mon, Mar 25, 2019 at 10:40:42AM +0000, Adriaan de Groot wrote: > > > New Revision: 496814 > > > URL: https://svnweb.freebsd.org/changeset/ports/496814 > > > > > > Log: > > > New ports security/olm and net-im/mtxclient > > > > > > These are support libraries for Matrix clients; Nheko in particular. > > > Until I wrap-up Nheko, they aren't used by anything. > > > > > Added: head/net-im/mtxclient/Makefile > > ... > > + > > +BUILD_DEPENDS= nlohmann-json>=3:devel/nlohmann-json \ > > + googletest>0:devel/googletest Sorry I've misquoted this part in the first mail due to fat-fingering. > "that's gross" is not a particularly meaningful comment. I have no idea > what you're getting at (especially not four months after-the-fact). Yeah, I now realize how stupid it looked. :-( I was talking about the bdep on `devel/googletest'. > > Would you kindly consider dropping the hard dependency and adding > > CMAKE_ARGS= -DBUILD_LIB_TESTS:BOOL=OFF instead? > > Sure. Generally I package things up with as little change from upstream > as possible. By default mtxclient **does** build tests, and to do so has > certain straightforward dependencies. I don't usually see a reason to > reduce testing or validity checking during builds. > > So .. whatevs? It's just a build dep, doesn't affect the installed > package at all. The thing is that 1) many of us build their packages from ports, and 2) if it's a test-related dependency, could it be converted to TEST_DEPENDS instead? ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200813113241.GA80435>