From owner-freebsd-current@FreeBSD.ORG Sun Jun 30 08:28:03 2013 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 2A8DDA7C for ; Sun, 30 Jun 2013 08:28:03 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wi0-x22d.google.com (mail-wi0-x22d.google.com [IPv6:2a00:1450:400c:c05::22d]) by mx1.freebsd.org (Postfix) with ESMTP id B97D01796 for ; Sun, 30 Jun 2013 08:28:02 +0000 (UTC) Received: by mail-wi0-f173.google.com with SMTP id hq4so2154740wib.0 for ; Sun, 30 Jun 2013 01:28:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=4avMrwWNZC/eHNlTxDUc2/AWv8wH4YOGPBpcyFbUbHE=; b=uHHZ9O6isOpFcq6idfHjb7gWaeShlsbpwe408SFnEKBl93onLHtrwdjmGJaXqC9Zqv 1AoFs3lZj3CTibYK8Ra8+zY4M7g0YMTi5+9ORZU4fEuTKPWjVDJ7FZvfCFk3ezMlLHcJ 3IiPFP6iHMTtS+X9Mp985zX7ZedeQciwpmScdBTbHGVureYjzNCfgZ1yIbGskXcDLM+y p+7gFjLUauezcgxgh7kduv/zEvuZsrc19Pgt4SBm9XIxwVIHap//n9k/v1k1/LJ3CGwY Dxy2Jk2b+rPqmb+n/Cy7fBlEwN100kBfYi9GvBY/H2nbLOdv4lPKPhp+KvkMOS66LPAo xIow== X-Received: by 10.180.96.227 with SMTP id dv3mr9144117wib.59.1372580881862; Sun, 30 Jun 2013 01:28:01 -0700 (PDT) Received: from dft-labs.eu (n1x0n-1-pt.tunnel.tserv5.lon1.ipv6.he.net. [2001:470:1f08:1f7::2]) by mx.google.com with ESMTPSA id ev19sm8479940wid.2.2013.06.30.01.28.00 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 30 Jun 2013 01:28:00 -0700 (PDT) Date: Sun, 30 Jun 2013 10:27:57 +0200 From: Mateusz Guzik To: Alexander Leidinger Subject: Re: panic: Lock filedesc structure not share locked Message-ID: <20130630082756.GA22492@dft-labs.eu> References: <20130630094150.00004a9c@unknown> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20130630094150.00004a9c@unknown> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: current@FreeBSD.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Jun 2013 08:28:03 -0000 On Sun, Jun 30, 2013 at 09:41:50AM +0200, Alexander Leidinger wrote: > Hi, > > with head as of r252381 on amd64, I got the following panic after > starting tmux and creating a 2nd terminal window inside tmux > (ctrl- + c): > ---snip--- > panic: Lock filedesc structure not share locked @ /space/system/usr_src/sys/kern/kern_descrip.c:3448 > > cpuid = 2 > KDB: stack backtrace: > db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xffffff839ee566d0 > kdb_backtrace() at kdb_backtrace+0x39/frame 0xffffff839ee56780 > vpanic() at vpanic+0x126/frame 0xffffff839ee567c0 > panic() at panic+0x43/frame 0xffffff839ee56820 > _sx_assert() at _sx_assert+0x134/frame 0xffffff839ee56830 > _sx_sunlock() at _sx_sunlock+0x46/frame 0xffffff839ee56860 > kern_proc_filedesc_out() at kern_proc_filedesc_out+0x420/frame 0xffffff839ee568e0 > sysctl_kern_proc_filedesc() at sysctl_kern_proc_filedesc+0x66/frame 0xffffff839ee56950 > sysctl_root() at sysctl_root+0x1bd/frame 0xffffff839ee569a0 > userland_sysctl() at userland_sysctl+0x192/frame 0xffffff839ee56a40 > sys___sysctl() at sys___sysctl+0x74/frame 0xffffff839ee56af0 > amd64_syscall() at amd64_syscall+0x23c/frame 0xffffff839ee56bf0 > Xfast_syscall() at Xfast_syscall+0xfb/frame 0xffffff839ee56bf0 > ---snip--- > Can you try this (only compile-tested): diff --git a/sys/kern/kern_descrip.c b/sys/kern/kern_descrip.c index e760fe5..7aa17cd 100644 --- a/sys/kern/kern_descrip.c +++ b/sys/kern/kern_descrip.c @@ -3272,6 +3272,8 @@ export_fd_to_sb(void *data, int type, int fd, int fflags, int refcnt, if (efbuf->remainder < kif->kf_structsize) { /* Terminate export. */ efbuf->remainder = 0; + if (!locked && efbuf->fdp != NULL) + FILEDESC_SLOCK(efbuf->fdp); return (0); } efbuf->remainder -= kif->kf_structsize; -- Mateusz Guzik