From nobody Fri Jun 20 13:52:27 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bNzSD5j8sz5y3yK; Fri, 20 Jun 2025 13:52:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bNzSC6mT4z3Xw7; Fri, 20 Jun 2025 13:52:27 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1750427548; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LZfQCNsJK2VqV/oELrrmWhbYJB8BmSQH3jLEU0aGn5I=; b=E/psZ7Nz7nP/tvqrafRFKwQ50PeLhCY06akEdnCP39PFby3JTymytv5XSDgJz9OifUCkYg n6KtRXqdsq1S3Q2fgMvtnEJF7l7VSrd1+Izq1XFT133v6xp7hk0G3GC52VWdrssBsz4ePP 0rEFUB7EIUhKX/VCmBYAQRDDNj5taQWSqpy+DR3eJd+hpvtTPV2JsvlYlF1JQd0OXqfMmZ wReuxAOG840k23ZEBHcW0ZZV6Lk3t9I8gIcQGVnxkgUetPiSqUb4S/TzhffzsOpzEsCDQy wNz5Iuwku5NvubAYaOPsYV85QavD1VoSf40XADT/vSjkybZg0L4jHkH9iXOs0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1750427548; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LZfQCNsJK2VqV/oELrrmWhbYJB8BmSQH3jLEU0aGn5I=; b=xU9r91+g6laWGP7MTBpQCCiI4NsNxurMF3wPDYpBHiS7GwNBvib2kVXgOgma0+p+yoHtNZ Kc8SYSE3/8deFVCIgQyvqTDn4WQQ4ySX7xlQwpf7ky9TfnmvwLIaBhZhSJ/JXqHSTwqawY McaNZ9ej9f4r4jK1LVIQcqmVkAsdY9oyrGLYja9uV00wpsPh3pEmwBHDDTRiX9cHeTrcp4 IMW1wQ4sPhYQgJ9x/MXmDYLj7GmbQAPmitZU+/AKzCrnvwJ99d98G2xzr0iD/khWMDZze4 fq6Vb9omtl5eNxX66AGIrljne3dJjghOkZBGREOYBzDvXgqP2Ru0sRuqwg7CpA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1750427548; a=rsa-sha256; cv=none; b=rPpgSH8fNzJtU17lFWddgpsKnAZj1K9OutP/+HtkIbr5MjimY6fLiGTbyfshyouXHpsL3k zZC4VuYaToqrvzEDhZZhX4JPsC19XdMCWhagvyzsVMZ/njI5dLW/2UO7airnJXBesBHefj pnH0fY52grgL4aYoH4QDJ56Qv8YCXhXDlGQ6GQF4xkDxWbgeVrEe2Z93RVBoNpzRpHPuCp 7SmQMipOOPqoGJ8tb/aTUSEER0haNRHfOyvN7pFSaqN6rXJghNEZATQqtPGVAN4BXpaiaB eswrxf1/SlsQIczv++EEwC7mMRuEVoOnknTDUiLdQbIGi9bLgftqAsG692enVg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bNzSC621czp76; Fri, 20 Jun 2025 13:52:27 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 55KDqR31058192; Fri, 20 Jun 2025 13:52:27 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 55KDqRgC058189; Fri, 20 Jun 2025 13:52:27 GMT (envelope-from git) Date: Fri, 20 Jun 2025 13:52:27 GMT Message-Id: <202506201352.55KDqRgC058189@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 0d698e74fb6b - stable/14 - devfs: Set eofflag in devfs_readdir() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 0d698e74fb6b188037fffb626efc050e41b5afcd Auto-Submitted: auto-generated The branch stable/14 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=0d698e74fb6b188037fffb626efc050e41b5afcd commit 0d698e74fb6b188037fffb626efc050e41b5afcd Author: Mark Johnston AuthorDate: 2025-05-29 18:25:56 +0000 Commit: Mark Johnston CommitDate: 2025-06-20 12:47:27 +0000 devfs: Set eofflag in devfs_readdir() At least vn_dir_next_dirent() checks that eofflag is set appropriately when INVARIANTS is enabled, so the omission here could cause an assertion failure. Reviewed by: kib MFC after: 2 weeks Sponsored by: Klara, Inc. Differential Revision: https://reviews.freebsd.org/D50598 (cherry picked from commit 198d2ed2d4c6c921928a9175f825d0d8345e5a46) --- sys/fs/devfs/devfs_vnops.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/fs/devfs/devfs_vnops.c b/sys/fs/devfs/devfs_vnops.c index 7d17362df05e..4b6845602218 100644 --- a/sys/fs/devfs/devfs_vnops.c +++ b/sys/fs/devfs/devfs_vnops.c @@ -1517,6 +1517,8 @@ devfs_readdir(struct vop_readdir_args *ap) */ if (tmp_ncookies != NULL) ap->a_ncookies = tmp_ncookies; + if (dd == NULL && error == 0 && ap->a_eofflag != NULL) + *ap->a_eofflag = 1; return (error); }