From owner-cvs-src@FreeBSD.ORG Sun Sep 26 11:48:43 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B261816A4CE; Sun, 26 Sep 2004 11:48:43 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A761343D39; Sun, 26 Sep 2004 11:48:43 +0000 (GMT) (envelope-from sos@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i8QBmhkC005847; Sun, 26 Sep 2004 11:48:43 GMT (envelope-from sos@repoman.freebsd.org) Received: (from sos@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i8QBmhBC005846; Sun, 26 Sep 2004 11:48:43 GMT (envelope-from sos) Message-Id: <200409261148.i8QBmhBC005846@repoman.freebsd.org> From: Søren Schmidt Date: Sun, 26 Sep 2004 11:48:43 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/dev/ata ata-all.c ata-all.h ata-disk.c ata-lowlevel.c ata-queue.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Sep 2004 11:48:43 -0000 sos 2004-09-26 11:48:43 UTC FreeBSD src repository Modified files: sys/dev/ata ata-all.c ata-all.h ata-disk.c ata-lowlevel.c ata-queue.c Log: Remove the old ATA_*LOCK_CH macros that used atomic ops and use mutexes instead. This closes the last (known) race issues in ATA which should fix the various hangs etc seen on heavy loaded systems. Change from using timeout functions to using callout functions in the timeout code. This together with above closes the race that could happen if timeout and device interrupt occured simultaniously. Also fix the possible recursion in ata_reinit() on very dodgy devices that could take us down in the probe. Revision Changes Path 1.228 +109 -12 src/sys/dev/ata/ata-all.c 1.84 +10 -19 src/sys/dev/ata/ata-all.h 1.178 +2 -1 src/sys/dev/ata/ata-disk.c 1.48 +26 -69 src/sys/dev/ata/ata-lowlevel.c 1.35 +111 -114 src/sys/dev/ata/ata-queue.c