From owner-freebsd-ports Fri Apr 17 00:10:29 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id AAA21719 for freebsd-ports-outgoing; Fri, 17 Apr 1998 00:10:29 -0700 (PDT) (envelope-from owner-freebsd-ports@FreeBSD.ORG) Received: (from gnats@localhost) by hub.freebsd.org (8.8.8/8.8.8) id AAA21615; Fri, 17 Apr 1998 00:10:17 -0700 (PDT) (envelope-from gnats) Date: Fri, 17 Apr 1998 00:10:17 -0700 (PDT) Message-Id: <199804170710.AAA21615@hub.freebsd.org> To: freebsd-ports Cc: From: Matthew Hunt Subject: ports/5805: saoimage Reply-To: Matthew Hunt Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org The following reply was made to PR ports/5805; it has been noted by GNATS. From: Matthew Hunt To: freebsd-gnats-submit@freebsd.org Cc: Subject: ports/5805: saoimage Date: Fri, 17 Apr 1998 03:06:03 -0400 I have reviewed the port of saoimage by giffunip@asme.org. I have made some changes so that it honors CC and CFLAGS. I defined USE_X11. It passes portlint, except for a warning about the length of pkg/DESCR. Packages and deletes correctly. I have used saoimage in my work, and I briefly verified that it is operating correctly by viewing a FITS file containing data from the Hale 200-inch telescope. I didn't use it much, because I have a low-resolution 24-bit display, and saoimage likes high-resolution 8-bit displays. :-) AeOA I once spent the better part of an evening starting a port of IRAF. I decided it was a Thing Better Left Undone. Anyone who disagrees can go to iraf.noao.edu and knock himself out. diff -urN saoimage.orig/Makefile saoimage/Makefile --- saoimage.orig/Makefile Fri Feb 20 20:02:47 1998 +++ saoimage/Makefile Fri Apr 17 02:57:00 1998 @@ -3,7 +3,7 @@ # Date created: 21 Feb 1998 # Whom: giffunip@asme.org # -# $Id: Makefile,v 1.17 1997/09/23 21:01:13 ache Exp $ +# $Id$ # DISTNAME= saoimage-1.22 @@ -16,7 +16,8 @@ ALL_TARGET= FreeBSD INSTALL_TARGET= -f makefile.$(ALL_TARGET) install_saobin install_saoman -MANL= saoimage.l +MANL= saoimage.l +USE_X11= yes pre-patch: $(CP) $(WRKSRC)/makefile.sun $(WRKSRC)/makefile.$(ALL_TARGET) diff -urN saoimage.orig/patches/patch-aa saoimage/patches/patch-aa --- saoimage.orig/patches/patch-aa Fri Feb 20 19:55:57 1998 +++ saoimage/patches/patch-aa Fri Apr 17 02:40:01 1998 @@ -1,5 +1,5 @@ -*** makefile.FreeBSD.orig Fri Feb 20 19:28:43 1998 ---- makefile.FreeBSD Fri Feb 20 19:54:57 1998 +*** makefile.FreeBSD.orig Fri Apr 17 02:36:13 1998 +--- makefile.FreeBSD Fri Apr 17 02:39:37 1998 *************** *** 1,5 **** # @@ -35,6 +35,23 @@ IMTOOLRC = $(IMTRCDIR)imtoolrc FIFO_I = $(ROOT)/dev/imt1i *************** +*** 46,52 **** + FIFO_LN = $(ROOT)/dev/imt1 + + # Compiler specification. +! CC = cc + # Uncomment these two lines to compile with gcc (add any optimizers you wish). + #CC = gcc -finline-functions -fdelayed-branch -fstrength-reduce + # Delayed branches could win big on RISC: many inner loops have branches +--- 46,52 ---- + FIFO_LN = $(ROOT)/dev/imt1 + + # Compiler specification. +! #CC = cc + # Uncomment these two lines to compile with gcc (add any optimizers you wish). + #CC = gcc -finline-functions -fdelayed-branch -fstrength-reduce + # Delayed branches could win big on RISC: many inner loops have branches +*************** *** 62,86 **** # fired up on a system where the fifos are absent. Other than this, the # standalone operation is unhindered. @@ -79,7 +96,7 @@ # OFLAGS: compiler optimization/debug options. ! #OFLAGS = -g -DDEBUG -! OFLAGS = -O2 -m486 -pipe +! #OFLAGS = -O2 -m486 -pipe # ADFLAGS: architecture-dependent floating point flags, etc. @@ -89,7 +106,7 @@ # Libraries that move about or may require special specification. # *************** -*** 88,104 **** +*** 88,110 **** # usual link search path, i.e., it is not in /usr/lib, it may be necessary # to specify its path fully in XLIB. @@ -107,7 +124,13 @@ MV = mv -f RANLIB = ranlib RM = rm -f ---- 89,106 ---- + SHELL = /bin/sh + +! CFLAGS = $(OFLAGS) $(ADFLAGS) $(MFLAGS) $(IFLAGS) -DFBCONFIG_2=\"$(IMTOOLRC)\" + + # SAOimage libraries that live in subdirectories with their own makefiles. + # This definition must be kept in correspondence with the DEPLIBS target. +--- 89,112 ---- # usual link search path, i.e., it is not in /usr/lib, it may be necessary # to specify its path fully in XLIB. @@ -126,6 +149,12 @@ MV = mv -f RANLIB = ranlib RM = rm -f + SHELL = /bin/sh + +! CFLAGS += $(ADFLAGS) $(MFLAGS) $(IFLAGS) -DFBCONFIG_2=\"$(IMTOOLRC)\" + + # SAOimage libraries that live in subdirectories with their own makefiles. + # This definition must be kept in correspondence with the DEPLIBS target. *************** *** 299,305 **** $(MAKE) ARCFILE=$(TAPEDEV) tar -- Matthew Hunt * Stay close to the Vorlon. http://mph124.rh.psu.edu/~mph/pgp.key for PGP public key 0x67203349. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message