Date: Wed, 23 Jul 2014 01:12:51 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Danilo Egea Gondolfo <danilo@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r362568 - head/net/delegate Message-ID: <20140723011251.GA84066@FreeBSD.org> In-Reply-To: <201407221901.s6MJ1KFf044852@svn.freebsd.org> References: <201407221901.s6MJ1KFf044852@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jul 22, 2014 at 07:01:20PM +0000, Danilo Egea Gondolfo wrote: > New Revision: 362568 > URL: http://svnweb.freebsd.org/changeset/ports/362568 > QAT: https://qat.redports.org/buildarchive/r362568/ > > Log: > - Don't strip the binary. This breaks the binary checksumming > - Introduce ADMIN variable > [...] > +# Strip breaks binary checksumming > +STRIP= I might be wrong, but even with stripped binaries those warnings about wrong checksums remained. Since they looked harmless, I've removed the STRIP= line. > -# Prevent "filesystem was touched prior to 'make install' phase" warning; > -# allow unattended (non-interactive) builds > - @${REINPLACE_CMD} -e 's,"$$(XDG)",& DGROOT=${WRKDIR},' \ > - ${WRKSRC}/Makefile > - @${REINPLACE_CMD} -E '/ADMIN/s,undef,admin@example.com, ; \ > - s,-F(esign|ver),& DGROOT=${WRKDIR},' ${WRKSRC}/src/Makefile I wonder how did you manage to pass tinderbox test without this code you just removed without any explanation in the commit log. I provided comment there for a reason. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140723011251.GA84066>