From owner-cvs-src@FreeBSD.ORG Sun Jul 31 06:30:22 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E4C7616A420; Sun, 31 Jul 2005 06:30:22 +0000 (GMT) (envelope-from nate@root.org) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7159643D45; Sun, 31 Jul 2005 06:30:22 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.5.50] (adsl-64-171-187-230.dsl.snfc21.pacbell.net [64.171.187.230]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id j6V6UKo5008163 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 30 Jul 2005 23:30:21 -0700 Message-ID: <42EC6FED.1060307@root.org> Date: Sat, 30 Jul 2005 23:30:05 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Colin Percival References: <20050731015716.16A2C16A440@hub.freebsd.org> In-Reply-To: <20050731015716.16A2C16A440@hub.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/cpufreq est.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Jul 2005 06:30:23 -0000 Colin Percival wrote: > cperciva 2005-07-31 01:57:05 UTC > > FreeBSD src repository > > Modified files: > sys/i386/cpufreq est.c > Log: > Remove the instruction to "contact the maintainer" for unrecognized > CPUs. Intel refuses to give me the information I need, and getting > more emails about this doesn't help. > > Revision Changes Path > 1.8 +1 -3 src/sys/i386/cpufreq/est.c > > > Index: src/sys/i386/cpufreq/est.c > diff -u src/sys/i386/cpufreq/est.c:1.7 src/sys/i386/cpufreq/est.c:1.8 > --- src/sys/i386/cpufreq/est.c:1.7 Sun Apr 10 19:57:47 2005 > +++ src/sys/i386/cpufreq/est.c Sun Jul 31 01:57:05 2005 > @@ -705,9 +705,7 @@ > if (error) { > printf( > "est: CPU supports Enhanced Speedstep, but is not recognized.\n" > - "est: Please update driver or contact the maintainer.\n" > - "est: cpu_vendor %s, msr %0jx, bus_clk, %x\n", > - cpu_vendor, msr, INTEL_BUS_CLK); > + ); > return (ENXIO); > } I would prefer we still print the MSR and cpu_vendor info, even if you remove the "contact maintainer" part. Also, most systems based on newer Pentium-M export the control info via acpi_perf so if acpi is active, we use those settings for est. -- Nate