From owner-cvs-all Fri Jan 31 11:35:30 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id ED55D37B401; Fri, 31 Jan 2003 11:35:27 -0800 (PST) Received: from sccrmhc01.attbi.com (sccrmhc01.attbi.com [204.127.202.61]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1FF4343E4A; Fri, 31 Jan 2003 11:35:27 -0800 (PST) (envelope-from julian@elischer.org) Received: from InterJet.elischer.org (12-232-168-4.client.attbi.com[12.232.168.4]) by sccrmhc01.attbi.com (sccrmhc01) with ESMTP id <200301311935250010086vqpe>; Fri, 31 Jan 2003 19:35:26 +0000 Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id LAA46029; Fri, 31 Jan 2003 11:35:24 -0800 (PST) Date: Fri, 31 Jan 2003 11:35:23 -0800 (PST) From: Julian Elischer To: John Baldwin Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, "Tim J. Robbins" Subject: RE: cvs commit: src/sys/kern subr_trap.c In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, 31 Jan 2003, John Baldwin wrote: > > On 31-Jan-2003 Julian Elischer wrote: > > > > do you know of any other problems? > > thread_statclock() has a similar problem as others have noticed: > > int > thread_statclock(int user) > { > struct thread *td = curthread; > > ... > if (td->td_mailbox != NULL) > td->td_usticks += ticks; > } > luckily this is not going to effect anyone at the moment because thread_statclock is only called for KSE processes but I'll go beat on it now.. > Prior to this commit, the 'ticks' variable was an argument to this > function, now it is using the global variable instead. This is > clearly wrong and along with the other breakages this commit has > introduced so far demonstrate a severe lack of testing or review > in this commit. We want to make RELENG_5 more stable as we approach > 5.1 not less if possible. There is nothing preventing you from > doing development work in side trees and only committing it when it > is tested and has been properly reviewed. Please back these changes > out and work on them locally until you have tested them and fully > reviewed them. > > > > > On Fri, 31 Jan 2003, John Baldwin wrote: > > > >> > >> On 31-Jan-2003 Tim J. Robbins wrote: > >> > tjr 2003/01/31 03:22:32 PST > >> > > >> > Modified files: > >> > sys/kern subr_trap.c > >> > Log: > >> > Use a local variable to store the number of ticks that elapsed in > >> > kernel mode instead of (unintentionally) using the global `ticks'. > >> > This error completely broke profiling. > >> > >> Perhaps we should really back out the 'upcall' change until the patch > >> has has some more review and bugs like this have been fixed. > >> > >> -- > >> > >> John Baldwin <>< http://www.FreeBSD.org/~jhb/ > >> "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ > >> > > > > -- > > John Baldwin <>< http://www.FreeBSD.org/~jhb/ > "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message