From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Apr 9 00:50:02 2008 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F2EF41065674 for ; Wed, 9 Apr 2008 00:50:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id CFD568FC22 for ; Wed, 9 Apr 2008 00:50:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m390o1lL058120 for ; Wed, 9 Apr 2008 00:50:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m390o1Z4058119; Wed, 9 Apr 2008 00:50:01 GMT (envelope-from gnats) Resent-Date: Wed, 9 Apr 2008 00:50:01 GMT Resent-Message-Id: <200804090050.m390o1Z4058119@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Michael Johnson Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0A93D106566C for ; Wed, 9 Apr 2008 00:44:51 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id ED8818FC14 for ; Wed, 9 Apr 2008 00:44:50 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m390iYeQ033784 for ; Wed, 9 Apr 2008 00:44:34 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.2/8.14.1/Submit) id m390iYKL033783; Wed, 9 Apr 2008 00:44:34 GMT (envelope-from nobody) Message-Id: <200804090044.m390iYKL033783@www.freebsd.org> Date: Wed, 9 Apr 2008 00:44:34 GMT From: Michael Johnson To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/122590: [PATCH] print/cups-base : fix cups.desktop so a browser really opens X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Apr 2008 00:50:02 -0000 >Number: 122590 >Category: ports >Synopsis: [PATCH] print/cups-base : fix cups.desktop so a browser really opens >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Apr 09 00:50:01 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Michael Johnson >Release: >Organization: >Environment: >Description: Add depends on devel/xdg-utils (which has no depends) and use 'xdg-open http://localhost:631/' instead of 'htmlview http://localhost:631' in the cups.desktop file. htmlview is not found in ports... Plus xdg-open works with GNOME, KDE, XFCE, and generic desktops. I thought about using devel/gvfs for gvfs-open but that would cause a dependency loop, plus I doubt KDE people would like that. =) >How-To-Repeat: >Fix: Patch attached with submission follows: Index: Makefile =================================================================== RCS file: /home/pcvs/ports/print/cups-base/Makefile,v retrieving revision 1.92 diff -u -r1.92 Makefile --- Makefile 2 Apr 2008 15:20:37 -0000 1.92 +++ Makefile 9 Apr 2008 00:39:24 -0000 @@ -7,6 +7,7 @@ PORTNAME= cups PORTVERSION= 1.3.7 +PORTREVISION= 1 DISTVERSIONSUFFIX= -source CATEGORIES= print MASTER_SITES= EASYSW/${PORTNAME}/${DISTVERSION} @@ -18,6 +19,7 @@ LIB_DEPENDS= jpeg.9:${PORTSDIR}/graphics/jpeg \ png.5:${PORTSDIR}/graphics/png \ tiff.4:${PORTSDIR}/graphics/tiff +RUN_DEPENDS= xdg-open:${PORTSDIR}/devel/xdg-utils CONFLICTS= LPRng-[0-9]* @@ -185,6 +187,7 @@ .endif post-patch: + @${REINPLACE_CMD} -e 's|htmlview|xdg-open|' ${WRKSRC}/desktop/cups.desktop @${REINPLACE_CMD} -e '/SILENT/d' ${WRKSRC}/Makedefs.in @${REINPLACE_CMD} -e '/share/s|/usr/share|${PREFIX}/share|g' ${WRKSRC}/Makefile @${REINPLACE_CMD} -e 's|/etc/cups|/usr/local/etc/cups|g' ${WRKSRC}/man/*.man* >Release-Note: >Audit-Trail: >Unformatted: