From nobody Wed Apr 29 14:50:19 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g5KwX4QD6z6bkjF for ; Wed, 29 Apr 2026 14:50:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g5KwW4YRKz4Kxy for ; Wed, 29 Apr 2026 14:50:19 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777474219; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bn7kGUhwzXc4WlVZExANVj5yUtV9N7+61TJEnfE0eHE=; b=AjsUR1jr4HVlurMlFCht4kmwnOFFZU8oxYj6bFl1+sFB1THI8kTY1L9O5DcQcK+8StmyDJ e1EwgG9VBeC4KxuzTy9vn7jymF1I/a75Y/fg7ssKUS/7EHuabcyuxIU+UM18Nxl4dwg0F5 +P5cCog8M2tb7y6lKd4D1QsjrG0NfDS5tkSN2kQ/zB8ZF74SbB4JkO/LRj/YvD9AqEK0z2 SxIK6wK3Zoj0RqNBIgW2loByg0Yjiij+LsCfAbuFPd5xGnNTNTVxHNjFRABW451P/w1SKh 4BQv3j8Z8s3EuZprrScm1QGN2jLk78OD2BwaN+klvzh1gvnx5kgqMt+vMoKGsA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1777474219; a=rsa-sha256; cv=none; b=wpiTCTFcq6E5vWFyleyaH54BFvtnC8cx9BcnPh/vO5z1zfr5xiuV9rFWn4foAiWSV2Th+e 7wadiJxRXV1Qxt0dsywfreLq0cD0sVhkgqPC2pvTw3T+BtvZMJiTZr7P3+WdQmAmQAsopp Sj6v15qYFAsKYvsIDLn7eJJ89opdDgE1MVICaHzIMJ40243OcZbDbPb0mMmZoPdW4bbGV4 pYTuuQF5gvjk4hFGFfkImJjwyM68u7EzBmIyKWyy8JE7lwPHb2Z6fINGOTNwOSfOeripns 9SXW8EklyQTHSJ0TeigBVSVPnDsO4HxrKBTIB2W4ul7tCEhj2llVkwAqbF36nw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777474219; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bn7kGUhwzXc4WlVZExANVj5yUtV9N7+61TJEnfE0eHE=; b=idXgf6NQwY+bCTvRUaf2ZYDOFbYzqZ0LvYQFlRy6c2YArKkZfE55tBfiWYgGYJ5BHk6ZWp hcgn9t5dCDLCJeEmE73fni3b/qLY22Hy1BvRHYwA48sN825IXRsvP2F3Tl2tpZfU0/TcpG 0mfSjQK4QxjMyMdVIFnAD0SmEzyv0RhsExMD3m+zaYtK4aRMHuZh1qbSvw+6IfJ1sGIypl PQ6MhposGhiTGjXfun/pzXli7hwxEu1wI0Js6opV8AjDavODGRnigsEhaThDiH0GkgudSM QcaLdim9kjI9RvuYGPiql9DXorDJI6EF28Or5fQFFyFnllzxXUUSk4xpcW06HQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4g5KwW32PYzlbv for ; Wed, 29 Apr 2026 14:50:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3cbdd by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 29 Apr 2026 14:50:19 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 5a5e7883a3bb - releng/13.5 - dhclient: Fix reallocation of dhclient script environments List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/releng/13.5 X-Git-Reftype: branch X-Git-Commit: 5a5e7883a3bb85cbdcf9e2fc0f40b0a391659c30 Auto-Submitted: auto-generated Date: Wed, 29 Apr 2026 14:50:19 +0000 Message-Id: <69f21aab.3cbdd.56436592@gitrepo.freebsd.org> The branch releng/13.5 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=5a5e7883a3bb85cbdcf9e2fc0f40b0a391659c30 commit 5a5e7883a3bb85cbdcf9e2fc0f40b0a391659c30 Author: Mark Johnston AuthorDate: 2026-04-27 20:56:21 +0000 Commit: Mark Johnston CommitDate: 2026-04-28 20:32:11 +0000 dhclient: Fix reallocation of dhclient script environments When the number of DHCP options exceeds a threshold, script_set_env() will reallocate the environment, stored as an array of pointers. The calculation of the array size failed to multiply by the pointer size, resulting in a smaller than expected buffer which admits out-of-bounds writes. Approved by: so Security: FreeBSD-SA-26:15.dhclient Security: CVE-2026-42511 Reported by: Joshua Rogers of AISLE Research Team (https://aisle.com/) --- sbin/dhclient/dhclient.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sbin/dhclient/dhclient.c b/sbin/dhclient/dhclient.c index 590b18ee6467..e8fcdb133dc4 100644 --- a/sbin/dhclient/dhclient.c +++ b/sbin/dhclient/dhclient.c @@ -2435,8 +2435,8 @@ script_set_env(struct client_state *client, const char *prefix, char **newscriptEnv; int newscriptEnvsize = client->scriptEnvsize + 50; - newscriptEnv = realloc(client->scriptEnv, - newscriptEnvsize); + newscriptEnv = reallocarray(client->scriptEnv, + newscriptEnvsize, sizeof(char *)); if (newscriptEnv == NULL) { free(client->scriptEnv); client->scriptEnv = NULL;