From owner-svn-src-head@freebsd.org Sun Oct 25 01:38:19 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B85A643C78C for ; Sun, 25 Oct 2020 01:38:19 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qv1-xf2d.google.com (mail-qv1-xf2d.google.com [IPv6:2607:f8b0:4864:20::f2d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CJgbG4hj1z4Ncs for ; Sun, 25 Oct 2020 01:38:18 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qv1-xf2d.google.com with SMTP id w5so2741859qvn.12 for ; Sat, 24 Oct 2020 18:38:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iRTbwqpnNLB7ZuzhLQqw7pDuYEeKjw6EKxFIQz2b3SU=; b=g3zSvCYi6+WnhxyaKimiTPcubC7qhyVuufU+/MVdH17mepLcJ80iOiYXiYsTzj5RzO YppKawmAD022TGo8j+hJC30fvk7B8m1A7Umd4Ouj33FO1ZhsOpCdC6upR/PFA52eHlsT f5SgAn25rhrtEibRX42rYFRzSftj0yS1VT2LJME1rzJ3KNoUwdgnyLmB9aEZmNTCH4ht irLiyzulwjI2fwY+ci9rgpoM5FuFOTVB14nI0w9v7n2VHUCDQlvDQKeVShQ7GI6hddL1 lcxvJu4CZBEkeVJFnRkLOHmO/MLRrODHj6gfs7PrJ4NSVd/E/eM+HEjsQ9UxKrcsgWl2 i93A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iRTbwqpnNLB7ZuzhLQqw7pDuYEeKjw6EKxFIQz2b3SU=; b=j9bdfxjkSBaaOxUNHBHu3RqzBdl5rGnbb45Dqy3fFqQ97tgrA1WFJw8fog7hSwIOd+ uTQoGWsmWAjxdXr4XsofPAorY+UFqJlaWKmXkd60W/FAtowJ1gN+QiohEJBbFBD2zRo6 ttEwz9aquAHBN6Crp/zIL5tq5VVYavwmKOCW6P2UzsxreME+RjVNTyNNVCQfMLiQH8a0 pauFFNwE2Jcb2woJC/cdSmA+2v4jeymYfhNoV4aaNpK6CsftcZZTuliBnDprzkXMmjW+ jp87kYx2YdNbGuodE99jGi/dVwDg+n2Zf6ncGQCoEsSQc/zqyZsnZBj5R2Tk8El6d9I8 9f2w== X-Gm-Message-State: AOAM531o8XqLtQVc8WqD0l0ApvS8Nd07FcIMXjRzW3Wr0BS02HTX5QlM DvIJqMAVSd2RU94qtIcOmffjYh2oVH1MgaV2mdXGmA== X-Google-Smtp-Source: ABdhPJz4YL7tRYFbCmjta1D1KOBP7EHsi2P0EQWQvreBVOAXXH99HEznZsibTRzdhVImkPrV1D2qp93kxDdMjtRBiZ0= X-Received: by 2002:a0c:aa1e:: with SMTP id d30mr6372132qvb.24.1603589897502; Sat, 24 Oct 2020 18:38:17 -0700 (PDT) MIME-Version: 1.0 References: <202010241023.09OANMcL075640@repo.freebsd.org> <20201024125206.GB38000@FreeBSD.org> <999a005e-1ef8-3c45-fb07-94a3b6ebce1b@selasky.org> <317231603546378@mail.yandex.ru> In-Reply-To: From: Warner Losh Date: Sat, 24 Oct 2020 19:38:06 -0600 Message-ID: Subject: Re: svn commit: r366993 - head/sys/net To: Ed Maste Cc: "Alexander V. Chernikov" , Hans Petter Selasky , Alexey Dokuchaev , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" X-Rspamd-Queue-Id: 4CJgbG4hj1z4Ncs X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=g3zSvCYi; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::f2d) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-3.08 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-1.06)[-1.065]; NEURAL_HAM_LONG(-0.97)[-0.966]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; NEURAL_HAM_SHORT(-1.05)[-1.046]; RCPT_COUNT_SEVEN(0.00)[7]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::f2d:from]; R_SPF_NA(0.00)[no SPF record]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_COUNT_TWO(0.00)[2]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; MAILMAN_DEST(0.00)[svn-src-head] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Oct 2020 01:38:19 -0000 On Sat, Oct 24, 2020 at 7:20 PM Ed Maste wrote: > On Sat, 24 Oct 2020 at 11:27, Warner Losh wrote: > > > >> Given we already have nice .clang-format, that does most of the job, > maybe it's worth considering looking into tweaking it further to fix this > part? > >> It would be nice if we could finally offload all formatting issues to > the tool and focus on the actual code :-) > > > > It would be nice if it produced one of the style(9) acceptable formats > without disrupting things already acceptable. That's been the big problem > with the tweaks to date... some things are fixed, others break. It's > getting a lot closer, though > > Upstream clang-format comes with a script that can integrate with git, > adding a `git clang-format` command. It will apply formatting to > modified lines, leaving unchanged ones alone. > As long as it's optional... Warner