Date: Tue, 19 Jul 2022 10:40:00 -0700 From: Cy Schubert <Cy.Schubert@cschubert.com> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Cy Schubert <cy@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: c112b84fd807 - main - Revert "x11/fvwm3: Fix FvwmIconMan module segfault" Message-ID: <20220719174000.E7F92130@slippy.cwsent.com> In-Reply-To: <YtbrUdyCPAlM6dCZ@FreeBSD.org> References: <202207191334.26JDYhAw010500@gitrepo.freebsd.org> <YtbrUdyCPAlM6dCZ@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <YtbrUdyCPAlM6dCZ@FreeBSD.org>, Alexey Dokuchaev writes: > On Tue, Jul 19, 2022 at 01:34:43PM +0000, Cy Schubert wrote: > > commit c112b84fd8076a19f30f0705a3c139ef360b101e > > > > Revert "x11/fvwm3: Fix FvwmIconMan module segfault" > > > > The maintainer misunderstood the meaning of the maintainer-feedback > > flag in bugzilla. > > This still does not explain if the fix was wrong or not. If it's wrong, > it should've been explained in the commit log, if it's correct then how > does reverting it help? The fix was not wrong. According to the maintainer, the patch fixed the bug. The maintainer set the maintainer-feedback which was mistakenly taken to mean approved. The maintainer didn't want it committed yet so more people could test it. -- Cheers, Cy Schubert <Cy.Schubert@cschubert.com> FreeBSD UNIX: <cy@FreeBSD.org> Web: http://www.FreeBSD.org NTP: <cy@nwtime.org> Web: https://nwtime.org e**(i*pi)+1=0
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20220719174000.E7F92130>