From owner-svn-src-head@freebsd.org Fri Dec 4 18:01:33 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C2487A414D6; Fri, 4 Dec 2015 18:01:33 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (heidi.turbocat.net [88.198.202.214]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 885931FDF; Fri, 4 Dec 2015 18:01:32 +0000 (UTC) (envelope-from hps@selasky.org) Received: from laptop015.home.selasky.org (unknown [62.141.129.119]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 746461FE023; Fri, 4 Dec 2015 19:01:23 +0100 (CET) Subject: Re: svn commit: r291699 - in head/sys: modules/mlxen ofed/drivers/net/mlx4 To: Konstantin Belousov References: <201512031456.tB3EuHVs030967@repo.freebsd.org> <20151204175737.GA2202@kib.kiev.ua> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Hans Petter Selasky Message-ID: <5661D55F.4050902@selasky.org> Date: Fri, 4 Dec 2015 19:03:11 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20151204175737.GA2202@kib.kiev.ua> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Dec 2015 18:01:33 -0000 On 12/04/15 18:57, Konstantin Belousov wrote: > On Thu, Dec 03, 2015 at 02:56:17PM +0000, Hans Petter Selasky wrote: >> Author: hselasky >> Date: Thu Dec 3 14:56:17 2015 >> New Revision: 291699 >> URL: https://svnweb.freebsd.org/changeset/base/291699 >> >> Log: >> Convert the mlxen driver to use the BUSDMA(9) APIs instead of >> vtophys() when loading mbufs for transmission and reception. While at >> it all pointer arithmetic and cast qualifier issues were fixed, mostly >> related to transmission and reception. >> >> MFC after: 1 week >> Sponsored by: Mellanox Technologies >> Differential Revision: https://reviews.freebsd.org/D4284 >> >> Modified: >> head/sys/modules/mlxen/Makefile >> head/sys/ofed/drivers/net/mlx4/en_netdev.c >> head/sys/ofed/drivers/net/mlx4/en_rx.c >> head/sys/ofed/drivers/net/mlx4/en_tx.c >> head/sys/ofed/drivers/net/mlx4/mlx4_en.h >> >> Modified: head/sys/modules/mlxen/Makefile >> ============================================================================== >> --- head/sys/modules/mlxen/Makefile Thu Dec 3 14:38:55 2015 (r291698) >> +++ head/sys/modules/mlxen/Makefile Thu Dec 3 14:56:17 2015 (r291699) >> @@ -11,5 +11,3 @@ CFLAGS+= -I${.CURDIR}/../../ofed/include >> CFLAGS+= -I${.CURDIR}/../../compat/linuxkpi/common/include >> >> .include >> - >> -CFLAGS+= -Wno-cast-qual -Wno-pointer-arith > > I did not checked to definitely blame this commit, but I do get the > following error from the i386 LINT build: > > In file included from /scratch/tmp/kib/src/sys/modules/mlxen/../../ofed/drivers/ > net/mlx4/en_cq.c:34: > In file included from /scratch/tmp/kib/src/sys/modules/mlxen/../../ofed/include/ > linux/mlx4/cq.h:39: > /scratch/tmp/kib/src/sys/modules/mlxen/../../ofed/include/linux/mlx4/doorbell.h: > 80:42: error: arithmetic on a pointer to void is a GNU extension [-Werror,-Wpoin > ter-arith] > __raw_writel((__force u32) val[1], dest + 4); > ~~~~ ^ I'll check it out. --HPS