From owner-cvs-all Sat Jun 22 23:21:30 2002 Delivered-To: cvs-all@freebsd.org Received: from cs.rice.edu (cs.rice.edu [128.42.1.30]) by hub.freebsd.org (Postfix) with ESMTP id 9B5DD37B401; Sat, 22 Jun 2002 23:21:26 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by cs.rice.edu (Postfix) with ESMTP id 9AB6B4AAC2; Sun, 23 Jun 2002 01:21:25 -0500 (CDT) Received: by cs.rice.edu (Postfix, from userid 19572) id 283344AAC0; Sun, 23 Jun 2002 01:21:25 -0500 (CDT) Date: Sun, 23 Jun 2002 01:21:25 -0500 From: Alan Cox To: Alfred Perlstein Cc: Alan Cox , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/vm vm_mmap.c Message-ID: <20020623062125.GH19727@cs.rice.edu> References: <200206230148.g5N1mN795443@freefall.freebsd.org> <20020623052710.GK53232@elvis.mu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020623052710.GK53232@elvis.mu.org> User-Agent: Mutt/1.3.28i X-Virus-Scanned: by AMaViS snapshot-20010714 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, Jun 22, 2002 at 10:27:10PM -0700, Alfred Perlstein wrote: > * Alan Cox [020622 18:48] wrote: > > alc 2002/06/22 18:48:23 PDT > > > > Modified files: > > sys/vm vm_mmap.c > > Log: > > o Remove the unnecessary acquisition and release of Giant around fdrop() > > in mmap(2). > > I think fdrop() may need Giant in case a race with a thread makes > it the instance of fdrop() that leads to fclose() being called which > can call down into the VFS code. > fdrop_locked(), which is called by fdrop(), acquires and releases Giant in the scenario that you describe. Alan To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message