From owner-svn-ports-all@freebsd.org Thu May 24 06:25:39 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 628F0F54575; Thu, 24 May 2018 06:25:39 +0000 (UTC) (envelope-from tobik@FreeBSD.org) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0B4C5780AF; Thu, 24 May 2018 06:25:38 +0000 (UTC) (envelope-from tobik@FreeBSD.org) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 5932D21C44; Thu, 24 May 2018 02:25:38 -0400 (EDT) Received: from web3 ([10.202.2.213]) by compute4.internal (MEProxy); Thu, 24 May 2018 02:25:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=8Gn0e3 dOql2bVrP3hBBX+ADxVbOT0ALFlcknfigl8QY=; b=dzO1mVDa+3uL6w+7FRPsIA 1Dwl1mCUm35Qx5dul6pTA+lykfNLBkWE2mmAnJzWHTYwz5Vi1qrcxUK4LMJCXXOK fsbBE+jTM+ZuGhRfdTEZEnl0YMmGak2TPOayb9A9ELTw1ATAtYFoYE/goaP/ssWm gtEt4uOEzbJNILiDhKSjxcSQl4e3+Op2bORdHypR3P6sJ8WU22UWp1LaxEY7NpSt /WdfqI9lZ35icEcIioUKeYMqTCr+ZMWU5Qu9x8mjVzOPgdQNow5QBaZsaojh2k1R R/jqMBoS52CZFmJX+vc3iobaWfUDXfKgsvwfisOLf6bbWE/wPbERmu7tv7t6/mjA == X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Received: by mailuser.nyi.internal (Postfix, from userid 99) id F3EDF9E3CA; Thu, 24 May 2018 02:25:37 -0400 (EDT) Message-Id: <1527143137.2894038.1383018096.245EB176@webmail.messagingengine.com> From: Tobias Kortkamp To: =?utf-8?Q?Fernando=20Apestegu=C3=ADa?= , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-a224ff37 Date: Thu, 24 May 2018 08:25:37 +0200 Subject: Re: svn commit: r470725 - in head/textproc/tkdiff: . files In-Reply-To: <201805232159.w4NLxYrK000782@repo.freebsd.org> References: <201805232159.w4NLxYrK000782@repo.freebsd.org> X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 May 2018 06:25:39 -0000 On Wed, May 23, 2018, at 23:59, Fernando Apestegu=C3=ADa wrote: > Author: fernape > Date: Wed May 23 21:59:34 2018 > New Revision: 470725 > URL: https://svnweb.freebsd.org/changeset/ports/470725 >=20 > Log: > textproc/tkdiff: port improvements >=20=20=20 > * add DESKTOP_ENTRY > * add converters/base64 as BUILD_DEPENDS > * add icons >=20=20=20 > Also give maintainership to portmaster@bsdforge.com >=20=20=20 > PR: 228176 > Submitted by: portmaster@bsdforge.com > Approved by: tcberner (mentor) > Differential Revision: https://reviews.freebsd.org/D15480 >=20 > Added: > head/textproc/tkdiff/files/ > head/textproc/tkdiff/files/icon128.base64 (contents, props changed) > head/textproc/tkdiff/files/icon256.base64 (contents, props changed) > head/textproc/tkdiff/files/icon32.base64 (contents, props changed) > head/textproc/tkdiff/files/icon64.base64 (contents, props changed) > Modified: > head/textproc/tkdiff/Makefile >=20 > Modified: head/textproc/tkdiff/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/textproc/tkdiff/Makefile Wed May 23 21:45:50 2018 (r470724) > +++ head/textproc/tkdiff/Makefile Wed May 23 21:59:34 2018 (r470725) > @@ -3,28 +3,42 @@ >=20=20 > PORTNAME=3D tkdiff > PORTVERSION=3D 4.2 > -PORTREVISION=3D 1 > +PORTREVISION=3D 2 > CATEGORIES=3D textproc tk > MASTER_SITES=3D SF >=20=20 > -MAINTAINER=3D ports@FreeBSD.org > +MAINTAINER=3D portmaster@BSDforge.com > COMMENT=3D Tk frontend for diff(1) >=20=20 > LICENSE=3D GPLv2 > LICENSE_FILE=3D ${WRKSRC}/LICENSE.txt >=20=20 > +BUILD_DEPENDS=3D base64>0:converters/base64 > + > WRKSRC=3D ${WRKDIR}/${PORTNAME}-unix >=20=20 > USES=3D tk:wrapper > NO_BUILD=3D yes >=20=20 > -PLIST_FILES=3D bin/tkdiff > +DESKTOP_ENTRIES=3D "Tkdiff" "Tk frontend for the diff command" \ > + "tkdiff" \ > + "tkdiff" "GNOME;GTK;Development;System;" \ > + false >=20=20 > +UNPACK=3D base64 -d > + > +PLIST_FILES=3D bin/tkdiff share/pixmaps/tkdiff.png share/pixmaps/ > tkdiff-256.png \ > + share/pixmaps/tkdiff-128.png share/pixmaps/tkdiff-64.png > + > post-patch: > ${FIND} ${WRKSRC} -type f | ${XARGS} \ > ${REINPLACE_CMD} -e '/^exec wish/s|wish|${WISH}|g' -e '/^exec tclsh/s| > tclsh|${TCLSH}|g' >=20=20 > do-install: > - @${INSTALL_SCRIPT} ${WRKSRC}/tkdiff ${STAGEDIR}${PREFIX}/bin > + ${INSTALL_SCRIPT} ${WRKSRC}/tkdiff ${STAGEDIR}${PREFIX}/bin > + ${UNPACK} ${FILESDIR}/icon256.base64 > ${STAGEDIR}${PREFIX}/share/ > pixmaps/tkdiff-256.png > + ${UNPACK} ${FILESDIR}/icon128.base64 > ${STAGEDIR}${PREFIX}/share/ > pixmaps/tkdiff-128.png > + ${UNPACK} ${FILESDIR}/icon64.base64 > ${STAGEDIR}${PREFIX}/share/ > pixmaps/tkdiff-64.png > + ${UNPACK} ${FILESDIR}/icon32.base64 > ${STAGEDIR}${PREFIX}/share/ > pixmaps/tkdiff.png >=20=20 > .include Hi, I have two questions. 1. Why not use base's `b64decode -r` instead of converters/base64? And this one goes to everyone: 2. print/jabref, misc/mc, editors/openoffice-devel, etc. seem to have binary files in files/*.png. Can we add new ones or is it forbidden now? It seems weird to have to base64 encode icons and decode them during the build.