From owner-freebsd-hackers@freebsd.org Fri Jun 12 20:12:41 2020 Return-Path: Delivered-To: freebsd-hackers@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 109453443C0 for ; Fri, 12 Jun 2020 20:12:41 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49kBjN6j8Tz41Bf; Fri, 12 Jun 2020 20:12:40 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-274.local (unknown [IPv6:2601:648:8203:2990:956d:aaea:1d3d:2765]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 98212293F2; Fri, 12 Jun 2020 20:12:40 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: maintaining CRYPTO_TIMING To: Mark Johnston Cc: freebsd-hackers@freebsd.org References: <20200612161401.GA3992@raichu> <37f0c691-f067-20e5-2c21-7513fbdc0380@FreeBSD.org> <20200612195619.GA14376@raichu> From: John Baldwin Autocrypt: addr=jhb@FreeBSD.org; keydata= mQGiBETQ+XcRBADMFybiq69u+fJRy/0wzqTNS8jFfWaBTs5/OfcV7wWezVmf9sgwn8TW0Dk0 c9MBl0pz+H01dA2ZSGZ5fXlmFIsee1WEzqeJzpiwd/pejPgSzXB9ijbLHZ2/E0jhGBcVy5Yo /Tw5+U/+laeYKu2xb0XPvM0zMNls1ah5OnP9a6Ql6wCgupaoMySb7DXm2LHD1Z9jTsHcAQMD /1jzh2BoHriy/Q2s4KzzjVp/mQO5DSm2z14BvbQRcXU48oAosHA1u3Wrov6LfPY+0U1tG47X 1BGfnQH+rNAaH0livoSBQ0IPI/8WfIW7ub4qV6HYwWKVqkDkqwcpmGNDbz3gfaDht6nsie5Z pcuCcul4M9CW7Md6zzyvktjnbz61BADGDCopfZC4of0Z3Ka0u8Wik6UJOuqShBt1WcFS8ya1 oB4rc4tXfSHyMF63aPUBMxHR5DXeH+EO2edoSwViDMqWk1jTnYza51rbGY+pebLQOVOxAY7k do5Ordl3wklBPMVEPWoZ61SdbcjhHVwaC5zfiskcxj5wwXd2E9qYlBqRg7QeSm9obiBCYWxk d2luIDxqaGJARnJlZUJTRC5vcmc+iGAEExECACAFAkTQ+awCGwMGCwkIBwMCBBUCCAMEFgID AQIeAQIXgAAKCRBy3lIGd+N/BI6RAJ9S97fvbME+3hxzE3JUyUZ6vTewDACdE1stFuSfqMvM jomvZdYxIYyTUpC5Ag0ERND5ghAIAPwsO0B7BL+bz8sLlLoQktGxXwXQfS5cInvL17Dsgnr3 1AKa94j9EnXQyPEj7u0d+LmEe6CGEGDh1OcGFTMVrof2ZzkSy4+FkZwMKJpTiqeaShMh+Goj XlwIMDxyADYvBIg3eN5YdFKaPQpfgSqhT+7El7w+wSZZD8pPQuLAnie5iz9C8iKy4/cMSOrH YUK/tO+Nhw8Jjlw94Ik0T80iEhI2t+XBVjwdfjbq3HrJ0ehqdBwukyeJRYKmbn298KOFQVHO EVbHA4rF/37jzaMadK43FgJ0SAhPPF5l4l89z5oPu0b/+5e2inA3b8J3iGZxywjM+Csq1tqz hltEc7Q+E08AAwUIAL+15XH8bPbjNJdVyg2CMl10JNW2wWg2Q6qdljeaRqeR6zFus7EZTwtX sNzs5bP8y51PSUDJbeiy2RNCNKWFMndM22TZnk3GNG45nQd4OwYK0RZVrikalmJY5Q6m7Z16 4yrZgIXFdKj2t8F+x613/SJW1lIr9/bDp4U9tw0V1g3l2dFtD3p3ZrQ3hpoDtoK70ioIAjjH aIXIAcm3FGZFXy503DOA0KaTWwvOVdYCFLm3zWuSOmrX/GsEc7ovasOWwjPn878qVjbUKWwx Q4QkF4OhUV9zPtf9tDSAZ3x7QSwoKbCoRCZ/xbyTUPyQ1VvNy/mYrBcYlzHodsaqUDjHuW+I SQQYEQIACQUCRND5ggIbDAAKCRBy3lIGd+N/BCO8AJ9j1dWVQWxw/YdTbEyrRKOY8YZNwwCf afMAg8QvmOWnHx3wl8WslCaXaE8= Message-ID: <5e5c9bc6-ffec-cb50-920c-777ecefb917a@FreeBSD.org> Date: Fri, 12 Jun 2020 13:12:39 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200612195619.GA14376@raichu> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jun 2020 20:12:41 -0000 On 6/12/20 12:56 PM, Mark Johnston wrote: > On Fri, Jun 12, 2020 at 12:46:27PM -0700, John Baldwin wrote: >> On 6/12/20 9:14 AM, Mark Johnston wrote: >>> Hi, >>> >>> I noticed that the opencrypto framework maintains counters for various >>> operations. These counters are all global and are updated >>> non-atomically, so they aren't SMP-friendly and won't be precise. I >>> wrote a patch to convert them to counter(9), which fixes both issues, >>> and I note that kern.crypto_stats was renamed to kern.crypto.stats in >>> HEAD so presumably we can use this opportunity to break the sysctl ABI >>> as well (the counters have to be widened from 32 bits to 64 bits). >>> Nothing in the base system seems to actually fetch these counters >>> outside of some code under tools/, which wasn't updated when the sysctl >>> was renamed. >> >> I think this is fine. I'd probably not oppose just removing the stats >> outright though. Not clear to me how useful they really are (I've never >> used them, always used dtrace or other stats that are more specific) > > I think the current stats are not particularly useful, but I could > imagine adding stats that might be. For instance, a counter for failed > CRYPTO_OP_VERIFY_DIGEST operations, or for operations handled by > software drivers vs. hardware drivers. I noticed while testing GELI > with a WIP driver that I had forgotten to implement AES-XTS+HMAC, so the > tests were causing GELI to fall back to a software implementation. > Counters could perhaps make it easier to spot cases where a consumer is > unexpectedly using an unaccelerated implementation. Or is there already > an easy way to spot that? I use a dtrace script for that sort of thing: https://github.com/bsdjhb/kdbg/blob/master/dtrace/crypto_drivers.d I have other dtrace scripts I haven't committed that are also useful (like printing out the 'csp' when creating sessions) For ccr I added counters for specific types of operations (ETA, GCM, CCM, cipher, and digest) that I also used when working on ccr(4). KTLS also has its own counters for ktls_ocf for TLS 1.2 vs 1.3. -- John Baldwin