From owner-freebsd-current Mon Jul 8 1:58:30 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CE97037B400; Mon, 8 Jul 2002 01:58:27 -0700 (PDT) Received: from mta5.snfc21.pbi.net (mta5.snfc21.pbi.net [206.13.28.241]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7C6FA43E31; Mon, 8 Jul 2002 01:58:27 -0700 (PDT) (envelope-from mtm@pacbell.net) Received: from kokeb.ambesa.net ([64.166.85.115]) by mta5.snfc21.pbi.net (iPlanet Messaging Server 5.1 (built May 7 2001)) with ESMTP id <0GYX001K7A9FQH@mta5.snfc21.pbi.net>; Mon, 08 Jul 2002 01:58:27 -0700 (PDT) Received: from kokeb.ambesa.net (smmsp@localhost [IPv6:::1]) by kokeb.ambesa.net (8.12.5/8.12.5) with ESMTP id g688wHVb060197; Mon, 08 Jul 2002 01:58:18 -0700 Received: (from mtm@localhost) by kokeb.ambesa.net (8.12.5/8.12.5/Submit) id g688dqGR059874; Mon, 08 Jul 2002 01:39:52 -0700 (PDT) Date: Mon, 08 Jul 2002 01:39:52 -0700 From: Mike Makonnen Subject: Re: benign bug in src/sys/kern/kern_resource.c:limcopy() ? In-reply-to: <20020708072042.GA49370@walton.maths.tcd.ie> To: David Malone Cc: freebsd-current@FreeBSD.ORG, alfred@FreeBSD.ORG Message-id: <20020708013952.105b9bfc.makonnen@pacbell.net> MIME-version: 1.0 X-Mailer: Sylpheed version 0.7.8 (GTK+ 1.2.10; i386-portbld-freebsd5.0) Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7BIT References: <20020707152851.3ddc58dc.makonnen@pacbell.net> <20020708072042.GA49370@walton.maths.tcd.ie> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, 08 Jul 2002 08:20:42 +0100 David Malone wrote: > > bcopy(&(lim->pl_rlimit[0]), &(copy->pl_rlimit[0]), > sizeof(lim->pl_rlimit)); > > rather than just copying the first limit? It might be better to just > bcopy the whole struct plimit and make a note that other fields need > to be reset. > yeah, you're right. I replaced one benign bug with a worse one. Alfred emailed me about it earlier, but I wasn't paying attention. Sorry :( Cheers, Mike Makonnen To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message