Date: Thu, 31 Mar 2016 16:47:59 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Adam Weinberger <adamw@adamw.org> Cc: Mark Felder <feld@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r411158 - in head/net: . socketw Message-ID: <20160331164759.GA81271@FreeBSD.org> In-Reply-To: <0955EF02-C11A-4C7B-A5E4-84065EC8A3FD@adamw.org> References: <201603151249.u2FCnBCu021587@repo.freebsd.org> <20160331150243.GA29515@FreeBSD.org> <1459437572.1257749.564801874.0692E203@webmail.messagingengine.com> <20160331153705.GA47404@FreeBSD.org> <0955EF02-C11A-4C7B-A5E4-84065EC8A3FD@adamw.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Mar 31, 2016 at 09:56:44AM -0600, Adam Weinberger wrote: > > On 31 Mar, 2016, at 9:37, Alexey Dokuchaev <danfe@FreeBSD.org> wrote: > > > > On Thu, Mar 31, 2016 at 10:19:32AM -0500, Mark Felder wrote: > >> On Thu, Mar 31, 2016, at 10:02, Alexey Dokuchaev wrote: > >>> On Tue, Mar 15, 2016 at 12:49:11PM +0000, Mark Felder wrote: > >>>> New Revision: 411158 > >>>> URL: https://svnweb.freebsd.org/changeset/ports/411158 > >>>> > >>>> [...] > >>>> +MAINTAINER= monwarez@mailoo.org > >>>> +COMMENT= SocketW is a cross platform streaming socket C++ > >>> > >>> Violation of Section 5.6 of the PHB (clause #2). > >> > >> Thanks, I'll correct that COMMENT ... > > > > It probably does not warrant a dedicated commit, you might want to hold > > it off until more substantial changes arrive. I sometimes have to wait > > years before fixing these types of mistakes because of lack of occasion. > > Is a fix still a fix if it never gets committed? As much as I hate needless SVN revision bumps, if I don't see another change coming soon, I'd still commit. It's just often one can actually group things together, albeit it does require some patience and overall software development "culture" to fully understand and appreciate the benefits thereof. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160331164759.GA81271>