From owner-svn-ports-all@freebsd.org  Thu Mar 31 16:47:59 2016
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 17DC5AE454A;
 Thu, 31 Mar 2016 16:47:59 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 0C9E61987;
 Thu, 31 Mar 2016 16:47:59 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 0B16B119B; Thu, 31 Mar 2016 16:47:59 +0000 (UTC)
Date: Thu, 31 Mar 2016 16:47:59 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Adam Weinberger <adamw@adamw.org>
Cc: Mark Felder <feld@FreeBSD.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject: Re: svn commit: r411158 - in head/net: . socketw
Message-ID: <20160331164759.GA81271@FreeBSD.org>
References: <201603151249.u2FCnBCu021587@repo.freebsd.org>
 <20160331150243.GA29515@FreeBSD.org>
 <1459437572.1257749.564801874.0692E203@webmail.messagingengine.com>
 <20160331153705.GA47404@FreeBSD.org>
 <0955EF02-C11A-4C7B-A5E4-84065EC8A3FD@adamw.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0955EF02-C11A-4C7B-A5E4-84065EC8A3FD@adamw.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 31 Mar 2016 16:47:59 -0000

On Thu, Mar 31, 2016 at 09:56:44AM -0600, Adam Weinberger wrote:
> > On 31 Mar, 2016, at 9:37, Alexey Dokuchaev <danfe@FreeBSD.org> wrote:
> > 
> > On Thu, Mar 31, 2016 at 10:19:32AM -0500, Mark Felder wrote:
> >> On Thu, Mar 31, 2016, at 10:02, Alexey Dokuchaev wrote:
> >>> On Tue, Mar 15, 2016 at 12:49:11PM +0000, Mark Felder wrote:
> >>>> New Revision: 411158
> >>>> URL: https://svnweb.freebsd.org/changeset/ports/411158
> >>>> 
> >>>> [...]
> >>>> +MAINTAINER=	monwarez@mailoo.org
> >>>> +COMMENT=	SocketW is a cross platform streaming socket C++
> >>> 
> >>> Violation of Section 5.6 of the PHB (clause #2).
> >> 
> >> Thanks, I'll correct that COMMENT ...
> > 
> > It probably does not warrant a dedicated commit, you might want to hold
> > it off until more substantial changes arrive.  I sometimes have to wait
> > years before fixing these types of mistakes because of lack of occasion.
> 
> Is a fix still a fix if it never gets committed?

As much as I hate needless SVN revision bumps, if I don't see another
change coming soon, I'd still commit.  It's just often one can actually
group things together, albeit it does require some patience and overall
software development "culture" to fully understand and appreciate the
benefits thereof.

./danfe