From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Feb 26 05:40:09 2004 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E7A2516A4CE for ; Thu, 26 Feb 2004 05:40:08 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id C90E743D3F for ; Thu, 26 Feb 2004 05:40:08 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i1QDe8bv033679 for ; Thu, 26 Feb 2004 05:40:08 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.10/8.12.10/Submit) id i1QDe8dV033678; Thu, 26 Feb 2004 05:40:08 -0800 (PST) (envelope-from gnats) Resent-Date: Thu, 26 Feb 2004 05:40:08 -0800 (PST) Resent-Message-Id: <200402261340.i1QDe8dV033678@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Osma Suominen Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 88B5A16A4CE for ; Thu, 26 Feb 2004 05:33:58 -0800 (PST) Received: from sange.fi (sange.fi [217.116.163.130]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0FF2A43D1F for ; Thu, 26 Feb 2004 05:33:58 -0800 (PST) (envelope-from ozone@oiva.sange.fi) Received: from ozone by oiva.sange.fi with local (Exim 4.22) id 1AwLeF-000Iig-Ms; Thu, 26 Feb 2004 15:33:55 +0200 Message-Id: Date: Thu, 26 Feb 2004 15:33:55 +0200 From: Osma Suominen To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 cc: admin@sange.fi Subject: ports/63389: lang/php4 doesn't read PHP4_OPTIONS from Makefile.local anymore X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Osma Suominen List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Feb 2004 13:40:09 -0000 >Number: 63389 >Category: ports >Synopsis: lang/php4 doesn't read PHP4_OPTIONS from Makefile.local anymore >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Feb 26 05:40:08 PST 2004 >Closed-Date: >Last-Modified: >Originator: Osma Suominen >Release: FreeBSD 4.8-RC i386 >Organization: Coop Sange >Environment: System: FreeBSD oiva.sange.fi 4.8-RC FreeBSD 4.8-RC #2: Thu Mar 6 19:04:51 EET 2003 root@oiva.sange.fi:/fs/syst/usr/obj/fs/syst/usr/src/sys/OIVA i386 >Description: lang/php4 Makefile allows options to be read from various places instead of having to set them on each install, which is good. I had placed my options in /usr/ports/lang/php4/Makefile.local However, it seems the mega-patch for PR 57699 (Makefile CVS rev 1.30) moved the inclusion of bsd.port.pre.mk down. This means that Makefile.local is now included only after options have been chosen, so setting PHP4_OPTIONS there has no effect. I know there are other ways of specifying PHP options. For me, a magic php4_options file is not very intuitive; a Makefile.local in the expected place is much better. >How-To-Repeat: cd /usr/ports/lang/php4 Create a file Makefile.local and specify some options there: --clip-- PHP4_OPTIONS= MYSQL IMAP --clip-- Run make The default options are used instead of the ones specified in Makefile.local >Fix: Solution 1: Move the inclusion of bsd.port.pre.mk back above the options stuff. This will probably break things that were reported in PR 57699 (OpenLDAP, MySQL) and fixed in Makefile 1.30. Maybe there are other ways to fix those? Solution 2: Hard-code the inclusion of Makefile.local (and Makefile.inc, while you're at it) so it is done before determining options. Not very pretty but does the job I believe. Solution 3: Decide that writing options in Makefile.local (and/or .inc) is not a supported way of selecting options, and document it in the beginning of the Makefile. >Release-Note: >Audit-Trail: >Unformatted: