From owner-svn-src-all@freebsd.org Wed Mar 1 23:14:38 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 88A50CF495D; Wed, 1 Mar 2017 23:14:38 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wr0-x244.google.com (mail-wr0-x244.google.com [IPv6:2a00:1450:400c:c0c::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1823F6C5; Wed, 1 Mar 2017 23:14:38 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by mail-wr0-x244.google.com with SMTP id u108so3426983wrb.2; Wed, 01 Mar 2017 15:14:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=f4FM8Cue9XS9MUMZO1yv17c0GdogSOR1AzoPZ6yrAL0=; b=b+I2t1X3TbO4rgbSAjkYJhB5PT5dQpaIzaygYxXs9UOnkXLhhwwrQAbssuNpDJWVvH 5mDBamVo2761+O2xeKWuXHn9tdxBMCDwOyy1HNEAzK3wtKL7vPWuAEVxedY0Ce9w9/es D5bzO6g8vBVNmt7R3XouC1/8InlhJIsb+yvCQNIrnMF8d+vHZ2V7Y+MI8k5X3hoeZTwJ u2L22osUapvw/cvcoucDj2z714ENGcoQSii2BCXDEp39bnYuhc0r5TREEOgslcrKQJM6 lfBEohlMDBPy3VRaQSyHUZmG4y9IGMrOyRTky0sdq8TbYpLb7P7YEBha532PdLGwp0p4 MJaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=f4FM8Cue9XS9MUMZO1yv17c0GdogSOR1AzoPZ6yrAL0=; b=EnrXChyyWtJSwFjPW5qJonjN1hQ3nlcGQ20sfVlPAEMsNofiVyCGYAQvY3oQMP1lZU H0Y/xgiwv2aZeLLDPX+weDIBqEHAjvoEb6dk7M5D8a3nM8YsXbS7eWs9rsGywIObLHzm ir+Z/EFCUq+BFijEFbTh6DvEE4/+GOLNUE9QV+Qb9mvOflsCSht2yjIQvCd0RxLt/KN2 sWLQO4eFk4YabTOVRIlTQYupvqX79vKn9KTMYjcoiHIsXraCyz064CZUdoou6DUgUSkS +R7baKHKoQoO0fXid7vHR+tyj/DRQpNf9tk27LhTC0B0XvWbgfom1urPx8VT2eEFPnUj aGrg== X-Gm-Message-State: AMke39mTm1plid4Yt7QXEgAFPhc9n5eIREQOugRcQfsP8Vfn0Yza+GXrhYUpscV11yLmIA== X-Received: by 10.223.163.206 with SMTP id m14mr10607016wrb.34.1488410075605; Wed, 01 Mar 2017 15:14:35 -0800 (PST) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id s26sm8447177wra.66.2017.03.01.15.14.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Mar 2017 15:14:34 -0800 (PST) Sender: Baptiste Daroussin Date: Thu, 2 Mar 2017 00:14:33 +0100 From: Baptiste Daroussin To: Ngie Cooper Cc: "Rodney W. Grimes" , Alexey Dokuchaev , src-committers , Ian Lepore , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r314464 - head/usr.sbin/yppush Message-ID: <20170301231433.ux6j2rxmey6xmhct@ivaldir.etoilebsd.net> References: <20170301165916.kuizbr2w5l2beoac@ivaldir.etoilebsd.net> <201703011708.v21H89XW057584@pdx.rh.CN85.dnsmgr.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4j4l23chfjqgui3u" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170206 (1.7.2) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 23:14:38 -0000 --4j4l23chfjqgui3u Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 01, 2017 at 02:41:23PM -0800, Ngie Cooper wrote: > On Wed, Mar 1, 2017 at 9:08 AM, Rodney W. Grimes > wrote: > ... > > At one point in history I can promise you that ALL symlinks in the rele= ase > > where shortest possible relative path. So any absolute links that ente= red > > the system got created by developers who where not aware that they shou= ld > > always use a relative link for anything landing in DESTDIR. This creat= es > > breakge on so many levels we should make a rapid correction to this > > regression. >=20 > This is why things are that way currently: >=20 > $ git blame usr.bin/chpass/Makefile| grep ypchfn > 780ae7713f72b (gjb 2016-01-28 01:15:57 +0000 29) SYMLINKS+=3D > ${BINDIR}/chpass ${BINDIR}/ypchfn > aca2488187113 (wosch 1997-09-13 12:21:25 +0000 35) MLINKS+=3D chpass.1 > ypchpass.1 chpass.1 ypchfn.1 chpass.1 ypchsh.1 > 5294f47313a2d (gjb 2016-01-28 02:56:30 +0000 39) .for i in chpass > chfn chsh ypchpass ypchfn ypchsh For thos in particular I think the right thing is actually to modify instal= l so if it creates hardlinks with chflags it should first check for chflags, rem= ove it make the hardlink and reapply. The issue would be that well you break wh= at chflags are for given you are workarounding it :) Bapt --4j4l23chfjqgui3u Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAli3VdAACgkQY4mL3PG3 PlriqBAA3IbSTeN4l0fB6FQqnMpf4McBKtmyHD0tA6CoXf+R+/d63t+KadLu/Ysh X8u7GiVYgXk/FXZMeDDQ/dvck3PvqB+QnE8PuLhXDgtY7qZHlcdXVxVn41Jrc+zy aKd0gW8jXxyIgwYOCODKKDwT7ClFid1X3JHZoOlrhSmglJwSXJ8oaYJGn4AmLEKd J/d+isiuZXU3xMnbnUTBdWDZucF03APb5w+jFIcIxu/R73uWl0w6WV1G/dE+6YIj pJ/N+VxDIJgqKoh8B/I7vuVSbbKfs0Yrx46O7MAeYYoNX5sM8R0PsTKT8Zx0URTf 46/wiHHiEiQesZSByM5f++JfKZJ0DGwlXNuqmWHsrAz2FX2g/V+9Z9kc3EXEgovS 6SGkEdUcMJpG+cTHup3nRxyPBL9qXo6VLlQOxZg4yqQp1hP56nAWYlB1BYLEPi5g ysYKKTob0nma2ZGo2o6vbD7B9ihoumdhfbzdge1KLnWb7fB07wMW3uqeNDNF+z1V giKEpyzK4+sspsBAb03rw+U9aXcB29+O197wJRn0AFFaStGub9bbAPW3/zsorzNJ EUXF3O9GC8mRyv13ZSvjYeJR3zAr4avImUjCUgOgGJOUdNpUxjKzVgYxESmBBazC osnYlHYWNUCHHwaQqgGpT3/5kcDdkKijHI7TBW2yTu9Ov8S4wZU= =5vrW -----END PGP SIGNATURE----- --4j4l23chfjqgui3u--