From owner-freebsd-gnome@FreeBSD.ORG Sun Oct 3 02:39:18 2010 Return-Path: Delivered-To: gnome@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 13A8F1065674 for ; Sun, 3 Oct 2010 02:39:18 +0000 (UTC) (envelope-from jhein@gossamer.timing.com) Received: from mout.perfora.net (mout.perfora.net [74.208.4.195]) by mx1.freebsd.org (Postfix) with ESMTP id D19628FC16 for ; Sun, 3 Oct 2010 02:39:17 +0000 (UTC) Received: from gossamer.timing.com ([206.168.13.144]) by mrelay.perfora.net (node=mrus2) with ESMTP (Nemesis) id 0Lllpg-1OStSp3qBU-00ZHsy; Sat, 02 Oct 2010 22:26:35 -0400 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="xWFuU/5WGn" Content-Transfer-Encoding: 7bit Message-ID: <19623.59863.344335.439131@gossamer.timing.com> Date: Sat, 2 Oct 2010 20:26:31 -0600 To: FreeBSD-gnats-submit@freebsd.org From: John Hein X-send-pr-version: 3.113 X-GNATS-Notify: X-Mailer: VM 8.0.12 under 22.3.1 X-Provags-ID: V02:K0:TUOFRqG1s3V98I7gOv2XAEkoZGWjaD+mjhzu3ROWqKR WfDb6/m4E4YyoUZzwDUhj1TlnllWi4dNSCSqcHKbJdLsG1skx2 BkQe9t+pv5RXaGKmFLPnqBHvB12g3ZddX8lIW0h7Gb2/RmPsCq dcD8ti+0gC6ad7ENlKnvXj20yPsBZqwi/xi2vPLZMkkGDcA3MC g9sT1dULoX6HIb4OhaBog== Cc: gnome@FreeBSD.org Subject: [patch] converters/fribidi fails to build if devel/glib20 is installed X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: John Hein List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Oct 2010 02:39:18 -0000 --xWFuU/5WGn Content-Type: text/plain; charset=us-ascii Content-Description: message body text Content-Transfer-Encoding: 7bit >Submitter-Id: current-users >Originator: John Hein >Organization: >Confidential: no >Synopsis: [patch] converters/fribidi fails to build if devel/glib20 is installed >Severity: non-critical >Priority: low >Category: ports >Class: sw-bug >Release: >Environment: FreeBSD 7-STABLE >Description: --with-glib=auto is the default 'configure' behavior. But 0.19.2 fails to link if glib is detected at the time configure is run: ../lib/.libs/libfribidi.so: undefined reference to `g_assert' The reason is that g_assert is not defined because glib/gtestutils.h is not included. This was noticed with glib-2.24.2, but likely occurs with other versions of glib, too. It was fixed in cvs upstream ... http://lists.freedesktop.org/archives/fribidi/2010-February/000598.html ... but no new release has been made. For 0.19.2 in ports, just use --without-glib (which is effectively how pointyhat builds it since glib is not a dependency). The patch below does that. It also fixes the URL in pkg-descr. >How-To-Repeat: Install devel/glib20. Then try to build converters/fribidi. >Fix: --xWFuU/5WGn Content-Type: text/plain; name="patch-without-glib" Content-Description: fix fribidi 0.19.2 if glib installed Content-Disposition: inline; filename="patch-without-glib" Content-Transfer-Encoding: 7bit Index: Makefile =================================================================== RCS file: /base/FreeBSD-CVS/ports/converters/fribidi/Makefile,v retrieving revision 1.22 diff -u -p -r1.22 Makefile --- Makefile 23 Aug 2009 17:17:33 -0000 1.22 +++ Makefile 3 Oct 2010 01:18:30 -0000 @@ -42,6 +42,8 @@ MAN3= fribidi_charset_to_unicode.3 frib CONFIGURE_ARGS= --disable-debug .endif +CONFIGURE_ARGS+= --without-glib + post-patch: @${SED} -e 's|%%LOCALBASE%%|${LOCALBASE}|g' < \ ${FILESDIR}/fribidi-config > ${WRKDIR}/fribidi-config Index: pkg-descr =================================================================== RCS file: /base/FreeBSD-CVS/ports/converters/fribidi/pkg-descr,v retrieving revision 1.3 diff -u -p -r1.3 pkg-descr --- pkg-descr 12 Sep 2005 07:29:08 -0000 1.3 +++ pkg-descr 3 Oct 2010 01:23:56 -0000 @@ -17,4 +17,4 @@ every Unicode character will be treated specification. The same is true for the mirroring of characters, which also works for all the characters listed as mirrorable in the Unicode specification. -WWW: http://fribidi.org/wiki/ +WWW: http://fribidi.org/ --xWFuU/5WGn--